xfs-masters
[Top] [All Lists]

[PATCH 2/2] workqueue: deprecate cancel_rearming_delayed_work[queue]()

To: linux-kernel@xxxxxxxxxxxxxxx
Subject: [PATCH 2/2] workqueue: deprecate cancel_rearming_delayed_work[queue]()
From: Tejun Heo <tj@xxxxxxxxxx>
Date: Tue, 14 Dec 2010 16:23:10 +0100
Cc: jgarzik@xxxxxxxxx, benh@xxxxxxxxxxxxxxxxxxx, mchehab@xxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, cbou@xxxxxxx, dwmw2@xxxxxxxxxxxxx, zbr@xxxxxxxxxxx, gregkh@xxxxxxx, bfields@xxxxxxxxxxxx, neilb@xxxxxxx, aelder@xxxxxxx, xfs-masters@xxxxxxxxxxx, cl@xxxxxxxxxxxxxxxxxxxx, penberg@xxxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, Trond.Myklebust@xxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx
In-reply-to: <4D078B6D.5060202@xxxxxxxxxx>
References: <4D078B6D.5060202@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.13) Gecko/20101207 Lightning/1.0b2 Thunderbird/3.1.7
There's no in-kernel user left for these two obsolete functions.  Mark
them deprecated and schedule for removal during 2.6.39 cycle.

Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
---
 Documentation/feature-removal-schedule.txt |   10 ++++++++++
 include/linux/workqueue.h                  |    4 ++--
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/Documentation/feature-removal-schedule.txt 
b/Documentation/feature-removal-schedule.txt
index 6c2f55e..4ff47de 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -564,3 +564,13 @@ Why:       This field is deprecated. I2C device drivers 
shouldn't change their
 Who:   Jean Delvare <khali@xxxxxxxxxxxx>

 ----------------------------
+
+What:  cancel_rearming_delayed_work[queue]()
+When:  2.6.39
+
+Why:   The functions have been superceded by cancel_delayed_work_sync()
+       quite some time ago.  The conversion is trivial and there is no
+       in-kernel user left.
+Who:   Tejun Heo <tj@xxxxxxxxxx>
+
+----------------------------
diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index 0c0771f..6b5193d 100644
--- a/include/linux/workqueue.h
+++ b/include/linux/workqueue.h
@@ -401,7 +401,7 @@ static inline bool __cancel_delayed_work(struct 
delayed_work *work)
 }

 /* Obsolete. use cancel_delayed_work_sync() */
-static inline
+static inline __deprecated
 void cancel_rearming_delayed_workqueue(struct workqueue_struct *wq,
                                        struct delayed_work *work)
 {
@@ -409,7 +409,7 @@ void cancel_rearming_delayed_workqueue(struct 
workqueue_struct *wq,
 }

 /* Obsolete. use cancel_delayed_work_sync() */
-static inline
+static inline __deprecated
 void cancel_rearming_delayed_work(struct delayed_work *work)
 {
        cancel_delayed_work_sync(work);

<Prev in Thread] Current Thread [Next in Thread>