xfs-masters
[Top] [All Lists]

Re: [xfs-masters] [PATCH -next] xfs: eliminate kconfig dependency warnin

To: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
Subject: Re: [xfs-masters] [PATCH -next] xfs: eliminate kconfig dependency warning
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 15 Oct 2010 07:55:02 +1100
Cc: Christoph Hellwig <hch@xxxxxx>, xfs-masters@xxxxxxxxxxx, lkml <linux-kernel@xxxxxxxxxxxxxxx>, akpm <akpm@xxxxxxxxxxxxxxxxxxxx>
In-reply-to: <4CB73B5B.30108@xxxxxxxxxx>
References: <20101013210142.9d524535.randy.dunlap@xxxxxxxxxx> <20101014092503.GA28446@xxxxxx> <4CB73B5B.30108@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Thu, Oct 14, 2010 at 10:18:19AM -0700, Randy Dunlap wrote:
> On 10/14/10 02:25, Christoph Hellwig wrote:
> > On Wed, Oct 13, 2010 at 09:01:42PM -0700, Randy Dunlap wrote:
> >> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> >>
> >> Fix kconfig dependency warning to satisfy dependencies:
> >>
> >> warning: (XFS_FS && BLOCK || NFSD && NETWORK_FILESYSTEMS && INET && 
> >> FILE_LOCKING && BKL) selects EXPORTFS which has unmet direct dependencies 
> >> (NETWORK_FILESYSTEMS)
> > 
> > I'm not entirely sure what this gibberish means, but I'm pretty sure it
> > does not make sense.
> > 
> > EXPORTFS is a small module that doesn't have any dependencie, and it's
> > needed by XFS for the by-handle operation, and by nfsd for the same
> > thing.  It has absolutely nothing to do with networking or network
> > filesystems (as in network filesystem clients).
> 
> The (kconfig) warning/problem is that exportfs is in the Networking 
> Filesystems menu,
> under the kconfig symbol NETWORK_FILESYSTEMS.

Thanks for the explanation, Randy.

> Dave Chinner wrote:
> | EXPORTFS functionality actually has use for local filesystems - the
> | open-by-handle interfaces in XFS are what uses it, and there are patches
> | about that make this generic for most filesystems. Hence it seems to
> | me that the correct thing to do is separate EXPORTFS from
> | NETWORK_FILESYSTEMS, not make local filesystems depend on a user
> | selecting network filesystem support....
> 
> Agreed.  Is that Kconfig change also part of the "patches about"?

I can't remember exactly what it does with the kconfig symbols.
Information about the patch series (including a link to the git repo
storing the changes) is here:

http://marc.info/?l=linux-fsdevel&m=128627415827161&w=2

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>