| To: | aelder@xxxxxxx |
|---|---|
| Subject: | Re: [PATCH] Fix xfs build when CONFIG_XFS_POSIX_ACL=n |
| From: | Randy Dunlap <randy.dunlap@xxxxxxxxxx> |
| Date: | Wed, 28 Jul 2010 10:25:49 -0700 |
| Cc: | "Luck, Tony" <tony.luck@xxxxxxxxx>, xfs-masters@xxxxxxxxxxx, linux-next@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, Dave Chinner <dchinner@xxxxxxxxxx> |
| In-reply-to: | <1280326978.2238.4.camel@doink> |
| Organization: | Oracle Linux Engineering |
| References: | <4c3f42cf1240489af5@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <20100726084829.b173ffe3.randy.dunlap@xxxxxxxxxx> <1280326978.2238.4.camel@doink> |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0 |
On 07/28/10 07:22, Alex Elder wrote: > On Mon, 2010-07-26 at 08:48 -0700, Randy Dunlap wrote: >> On Thu, 15 Jul 2010 10:18:07 -0700 Luck, Tony wrote: >> >>> When CONFIG_XFS_POSIX_ACL is not set "xfs_check_acl" is #defined >>> to NULL - which breaks the code attempting to add a tracepoint >>> on this function. >>> >>> Only define the tracepoint when the function exists. >>> >>> Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx> >> >> Acked-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx> >> >> Alex, can we get this merged for linux-next, please? >> This problem causes lots of xfs build errors in linux-next without this >> patch. > > Confirmed fixed as of today's linux-next build. -Alex Thanks. I'm not seeing those errors today. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Test, please ignore, Alex Elder |
|---|---|
| Previous by Thread: | Re: [PATCH] Fix xfs build when CONFIG_XFS_POSIX_ACL=n, Alex Elder |
| Next by Thread: | [PATCH 6/8] xfs: fix unsigned underflow, Kulikov Vasiliy |
| Indexes: | [Date] [Thread] [Top] [All Lists] |