Re: [PATCH] Fix xfs build when CONFIG_XFS_POSIX

xfs-masters

Re: [PATCH] Fix xfs build when CONFIG_XFS_POSIX_ACL=n

To:	"Luck, Tony" <tony.luck@xxxxxxxxx>
Subject:	Re: [PATCH] Fix xfs build when CONFIG_XFS_POSIX_ACL=n
From:	Christoph Hellwig <hch@xxxxxx>
Date:	Thu, 15 Jul 2010 20:00:38 +0200
Cc:	Alex Elder <aelder@xxxxxxx>, xfs-masters@xxxxxxxxxxx, linux-next@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, Dave Chinner <dchinner@xxxxxxxxxx>, Randy Dunlap <randy.dunlap@xxxxxxxxxx>
In-reply-to:	<4c3f42cf1240489af5@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
References:	<4c3f42cf1240489af5@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.3.28i

On Thu, Jul 15, 2010 at 10:18:07AM -0700, Luck, Tony wrote:
> When CONFIG_XFS_POSIX_ACL is not set "xfs_check_acl" is #defined
> to NULL - which breaks the code attempting to add a tracepoint
> on this function.
> 
> Only define the tracepoint when the function exists.
> 
> Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>

Thanks, that's much better than the stubbing changes I had prepared.


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] Fix xfs build when CONFIG_XFS_POSIX_ACL=n, Luck, Tony Re: [PATCH] Fix xfs build when CONFIG_XFS_POSIX_ACL=n, Christoph Hellwig <= Re: [PATCH] Fix xfs build when CONFIG_XFS_POSIX_ACL=n, Randy Dunlap Re: [PATCH] Fix xfs build when CONFIG_XFS_POSIX_ACL=n, Randy Dunlap Re: [PATCH] Fix xfs build when CONFIG_XFS_POSIX_ACL=n, Alex Elder Re: [PATCH] Fix xfs build when CONFIG_XFS_POSIX_ACL=n, Randy Dunlap

Previous by Date:	[PATCH] Fix xfs build when CONFIG_XFS_POSIX_ACL=n, Luck, Tony
Next by Date:	Re: [PATCH] Fix xfs build when CONFIG_XFS_POSIX_ACL=n, Randy Dunlap
Previous by Thread:	[PATCH] Fix xfs build when CONFIG_XFS_POSIX_ACL=n, Luck, Tony
Next by Thread:	Re: [PATCH] Fix xfs build when CONFIG_XFS_POSIX_ACL=n, Randy Dunlap
Indexes:	[Date] [Thread] [Top] [All Lists]