xfs-masters
[Top] [All Lists]

Re: [xfs-masters] INFO: possible circular locking dependency detected

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [xfs-masters] INFO: possible circular locking dependency detected
From: John Kacur <jkacur@xxxxxxxxxx>
Date: Sun, 11 Oct 2009 17:59:54 +0200 (CEST)
Cc: linux-kernel@xxxxxxxxxxxxxxx, xfs-masters@xxxxxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
In-reply-to: <20091011124616.GA4081@xxxxxx>
References: <alpine.LFD.2.00.0910110108160.4921@xxxxxxxxxxxxxxxxxxxxx> <20091011124616.GA4081@xxxxxx>
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)

On Sun, 11 Oct 2009, Christoph Hellwig wrote:

> This has been around for a long time, the VM calls into fput and thus
> ->release with the mmap_sem held, which makes it really hard for a
> filesystem to avoid a lock inversion if it uses a lock both in ->release
> and the I/O path.
> 
> I have a workaround for this to only acquire the XFS iolock with a
> trylock in the release path and leave cleaning up stale preallocations
> until the final iput.  It's not pretty, but given that we're unlikely
> to see the VM fixed I might aswell finally send it for inclusion.
> 

In seems very easy and reliable to reproduce on my machine - so I am happy 
to test the patch here when you're ready.

Thanks

John

<Prev in Thread] Current Thread [Next in Thread>