xfs-masters
[Top] [All Lists]

Re: [PATCH 6/9] drivers/media/video/uvc: Use %pUr to print UUIDs

To: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 6/9] drivers/media/video/uvc: Use %pUr to print UUIDs
From: Joe Perches <joe@xxxxxxxxxxx>
Date: Wed, 30 Sep 2009 17:24:10 -0700
Cc: linux-kernel@xxxxxxxxxxxxxxx, Adrian Hunter <adrian.hunter@xxxxxxxxx>, Alex Elder <aelder@xxxxxxx>, Artem Bityutskiy <dedekind@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Harvey Harrison <harvey.harrison@xxxxxxxxx>, Huang Ying <ying.huang@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Jeff Garzik <jgarzik@xxxxxxxxxx>, Matt Mackall <mpm@xxxxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>, Neil Brown <neilb@xxxxxxx>, Steven Whitehouse <swhiteho@xxxxxxxxxx>, xfs-masters@xxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx
In-reply-to: <200910010220.17534.laurent.pinchart@xxxxxxxxxxxxxxxx>
References: <cover.1254193019.git.joe@xxxxxxxxxxx> <111526fa2ce7f728d1f81465a00859c1780f0607.1254193019.git.joe@xxxxxxxxxxx> <200910010220.17534.laurent.pinchart@xxxxxxxxxxxxxxxx>
On Thu, 2009-10-01 at 02:20 +0200, Laurent Pinchart wrote:
> >             flags = info->flags;
> >             if (((flags & UVC_CONTROL_GET_CUR) && !(inf & (1 << 0))) ||
> >                 ((flags & UVC_CONTROL_SET_CUR) && !(inf & (1 << 1)))) {
> > -                   uvc_trace(UVC_TRACE_CONTROL, "Control "
> > -                           UVC_GUID_FORMAT "/%u flags don't match "
> > -                           "supported operations.\n",
> > -                           UVC_GUID_ARGS(info->entity), info->selector);
> > +                   uvc_trace(UVC_TRACE_CONTROL,
> > +                             "Control %pUr/%u flags don't match supported 
> > operations.\n",
> > +                             info->entity, info->selector);
> 
> This doesn't fit the 80 columns limit. Please run checkpatch.pl on your 
> patches.

Intentional.  Strings shouldn't be broken across lines unnecessarily.

> >                     snprintf(format->name, sizeof format->name,
> > -                           UVC_GUID_FORMAT, UVC_GUID_ARGS(&buffer[5]));
> > +                            "%pUr", &Buffer[5]);
> 
> Should be &buffer[5], not &Buffer[5]. You haven't compiled the patch, have
> you ? :-)

Unintentional.  Did compile allyesconfig.

cheers, Joe


<Prev in Thread] Current Thread [Next in Thread>