xfs-masters
[Top] [All Lists]

[Bug 845] xfs_repair does not warn when marking entries as bad if namech

To: xfs-masters@xxxxxxxxxxx
Subject: [Bug 845] xfs_repair does not warn when marking entries as bad if namecheck fails
From: bugzilla-daemon@xxxxxxxxxxx
Date: Mon, 17 Aug 2009 02:18:29 -0500
Auto-submitted: auto-generated
In-reply-to: <bug-845-113@xxxxxxxxxxxxxxxx/bugzilla/>
References: <bug-845-113@xxxxxxxxxxxxxxxx/bugzilla/>
http://oss.sgi.com/bugzilla/show_bug.cgi?id=845





--- Comment #10 from Roel van Meer <rolek@xxxxxxxxxx>  2009-08-17 02:17:21 CST 
---
(In reply to comment #8)

> entry at block 0 offset 800 in directory inode 128 has illegal name "/ile31":
> clearing entry

This is exactly what the patch was about. In my specific case (an entry with a
reference to an illegal inode and an illegal filename as well) both problems
are found, but when the second problem is remedied, no notice of this is
printed. As in my original post:

        - agno = 1
entry "/x0d" at block 0 offset 368 in directory inode 2153385427 references
invalid inode 18374686479671623679
        clearing inode number in entry at offset 368...
entry at block 0 offset 368 in directory inode 2153385427 has illegal name
"/x0d":         - agno = 2

You see that the line mentioning the "illegal name" is followed by nothing (not
even a newline). This is because the "invalid inode" problem triggers a piece
of code that does the same as the part when the junkit flag is set, only
without the warning statements. The attached patch fixes that.

I hope this clarifies it a bit.

Regards,

roel

-- 
Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

<Prev in Thread] Current Thread [Next in Thread>