xfs-masters
[Top] [All Lists]

Re: [PATCH v2 16/17] XFS: do not manipulate s_dirt directly

To: Artem Bityutskiy <dedekind@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2 16/17] XFS: do not manipulate s_dirt directly
From: Felix Blyakher <felixb@xxxxxxx>
Date: Thu, 4 Jun 2009 14:00:12 -0500
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx>, xfs-masters@xxxxxxxxxxx
In-reply-to: <1244112114-23144-17-git-send-email-dedekind@xxxxxxxxxxxxx>
References: <1244112114-23144-1-git-send-email-dedekind@xxxxxxxxxxxxx> <1244112114-23144-17-git-send-email-dedekind@xxxxxxxxxxxxx>

On Jun 4, 2009, at 5:41 AM, Artem Bityutskiy wrote:

From: Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx>

... use new VFS helpers instead.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx>
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Cc: xfs-masters@xxxxxxxxxxx
Cc: Felix Blyakher <felixb@xxxxxxx>

Acked-by: Felix Blyakher <felixb@xxxxxxx>


---
fs/xfs/linux-2.6/xfs_super.c |    6 +++---
fs/xfs/xfs_trans.c           |    2 +-
2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/xfs/linux-2.6/xfs_super.c b/fs/xfs/linux-2.6/ xfs_super.c
index d29218e..4c25456 100644
--- a/fs/xfs/linux-2.6/xfs_super.c
+++ b/fs/xfs/linux-2.6/xfs_super.c
@@ -1114,7 +1114,7 @@ xfs_fs_write_super(
{
        if (!(sb->s_flags & MS_RDONLY))
                xfs_sync_fsdata(XFS_M(sb), 0);
-       sb->s_dirt = 0;
+       mark_sb_clean(sb);
}

STATIC int
@@ -1141,7 +1141,7 @@ xfs_fs_sync_super(
                error = xfs_quiesce_data(mp);
        else
                error = xfs_sync_fsdata(mp, 0);
-       sb->s_dirt = 0;
+       mark_sb_clean(sb);

        if (unlikely(laptop_mode)) {
                int     prev_sync_seq = mp->m_sync_seq;
@@ -1447,7 +1447,7 @@ xfs_fs_fill_super(

        XFS_SEND_MOUNT(mp, DM_RIGHT_NULL, mtpt, mp->m_fsname);

-       sb->s_dirt = 1;
+       mark_sb_dirty(sb);
        sb->s_magic = XFS_SB_MAGIC;
        sb->s_blocksize = mp->m_sb.sb_blocksize;
        sb->s_blocksize_bits = ffs(sb->s_blocksize) - 1;
diff --git a/fs/xfs/xfs_trans.c b/fs/xfs/xfs_trans.c
index 8570b82..2552bae 100644
--- a/fs/xfs/xfs_trans.c
+++ b/fs/xfs/xfs_trans.c
@@ -629,7 +629,7 @@ xfs_trans_apply_sb_deltas(
                                  offsetof(xfs_dsb_t, sb_frextents) +
                                  sizeof(sbp->sb_frextents) - 1);

-       tp->t_mountp->m_super->s_dirt = 1;
+       mark_sb_dirty(tp->t_mountp->m_super);
}

/*
--
1.6.0.6


<Prev in Thread] Current Thread [Next in Thread>