xfs-masters
[Top] [All Lists]

Re: [xfs-masters] [PATCH 1/6] fsx: Use SEEK_END instead of the BSD'ish L

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [xfs-masters] [PATCH 1/6] fsx: Use SEEK_END instead of the BSD'ish L_XTND
From: Felix Blyakher <felixb@xxxxxxx>
Date: Wed, 13 May 2009 14:59:47 -0500
Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>, xfs-masters@xxxxxxxxxxx, "Theodore Ts'o" <tytso@xxxxxxx>
In-reply-to: <20090513185520.GA27763@xxxxxx>
References: <1242144865-6967-1-git-send-email-tytso@xxxxxxx> <4A0B12D3.8060305@xxxxxxxxxxx> <20090513185520.GA27763@xxxxxx>

On May 13, 2009, at 1:55 PM, Christoph Hellwig wrote:

On Wed, May 13, 2009 at 01:34:59PM -0500, Eric Sandeen wrote:
Theodore Ts'o wrote:
Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx>
---

Thanks Ted, first 5 look fine to me, but I don't think I'm The Decider
on patch 6.

Unless anyone else has objections? I'll merge these to the -dev repo on
kernel.org.

Looks good to me.  And I agree we should wait for SGI for patch 6.

Patches 1-5 look good to me too.

I'm not ready (and neither authorized) to comment on the patch 6
as it's not a my decision to make.
Seems like the usage of fsx at SGI goes further back than the
SCM history, but at the moment I didn't dig deeper on possible
changes prior to putting it in SCM. The history since in SCM is
correctly presented by Ted, and prealloc and flush options came
from SGI developers.

Anyway, I'm passing it to the legal department at SGI.

Felix

<Prev in Thread] Current Thread [Next in Thread>