Re: [PATCH 0/7] Cleanup code that think bio_alloc with __GFP

xfs-masters

Re: [PATCH 0/7] Cleanup code that think bio_alloc with __GFP_WAIT can fa

To:	Nikanth Karthikesan <knikanth@xxxxxxx>
Subject:	Re: [PATCH 0/7] Cleanup code that think bio_alloc with __GFP_WAIT can fail
From:	Jens Axboe <jens.axboe@xxxxxxxxxx>
Date:	Wed, 15 Apr 2009 08:55:21 +0200
Cc:	linux-kernel@xxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, tytso@xxxxxxx, adilger@xxxxxxx, Steven Whitehouse <swhiteho@xxxxxxxxxx>, xfs-masters@xxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>
In-reply-to:	<200904151034.52750.knikanth@xxxxxxx>
References:	<200904151034.52750.knikanth@xxxxxxx>

On Wed, Apr 15 2009, Nikanth Karthikesan wrote:
> bio_alloc will not fail when __GFP_WAIT is specified in the gfp_flags.
> See http://lkml.org/lkml/2009/4/14/198 for the discussion. But this
> not documented and there are places where there is unwanted code to
> handle bio_alloc failure even when __GFP_WAIT is specified. This patch
> set documents this and cleans up various callers who assume bio_alloc
> can fail even with __GFP_WAIT.

I added your patches 2-7, I substituted 1/7 with one I did myself that
uses proper kerneldoc annotation. Thanks!

-- 
Jens Axboe

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/7] Cleanup code that think bio_alloc with __GFP_WAIT can fail, Nikanth Karthikesan Re: [PATCH 0/7] Cleanup code that think bio_alloc with __GFP_WAIT can fail, Jens Axboe <=

Previous by Date:	[PATCH 6/7] xfs: Remove code handling bio_alloc failure with __GFP_WAIT, Nikanth Karthikesan
Next by Date:	Re: [PATCH 0/6] Handle bio_alloc failure, Nick Piggin
Previous by Thread:	[PATCH 0/7] Cleanup code that think bio_alloc with __GFP_WAIT can fail, Nikanth Karthikesan
Next by Thread:	[PATCH 6/7] xfs: Remove code handling bio_alloc failure with __GFP_WAIT, Nikanth Karthikesan
Indexes:	[Date] [Thread] [Top] [All Lists]