xfs-masters
[Top] [All Lists]

Re: linux-next: xfs tree build failure

To: David Chinner <david@xxxxxxxxxxxxx>, xfs-masters@xxxxxxxxxxx
Subject: Re: linux-next: xfs tree build failure
From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
Date: Thu, 12 Mar 2009 12:04:41 +1100
Cc: linux-next@xxxxxxxxxxxxxxx
In-reply-to: <20090310134547.e5d1d9ee.sfr@xxxxxxxxxxxxxxxx>
References: <20090310134547.e5d1d9ee.sfr@xxxxxxxxxxxxxxxx>
Hi David,

On Tue, 10 Mar 2009 13:45:47 +1100 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> 
wrote:
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> In file included from fs/xfs/support/debug.c:21:
> fs/xfs/xfs_error.h:137: error: expected declaration specifiers or '...' 
> before 'xfs_mount_t'
> fs/xfs/xfs_error.h:138: error: expected ')' before '*' token

This is still happening.

Looking at the preprocessed output. xfs_mount_t is not defined yet, so
either fs/xfs/xfs_error.h needs to include xfs_mount.h (in the DEBUG
case) or xfs_errortag_add and xfs_errortag_clearall need to use "struct
xfs_mount" as their paramaters instead of xfs_mount_t (and predeclare
"struct xfs_mount").

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgpu4mQuwmekr.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>