--- Comment #18 from Andras Korn <korn-sgi.com@xxxxxxxxxxxxxxxxxxxxxx>
2009-02-15 14:41:19 CST ---
No, what I meant was it would be ideal not to have to run xfs_repair at all.
The problem is that if this filesystem were being mounted at boot, from fstab,
and the mount failed, the boot process would basically stop, possibly leaving
the box inaccessible (e.g. if this was the rootfs). Sure, there are ways around
that, but they're expensive and/or painful.
This is handled for other filesystems by running fsck on them before mounting
(if they're dirty), but afaict fsck.xfs is a no-op: it's either mount, or
xfs_repair and lose journal data.
If I understand what you said about the patch correctly, mounting would be
impossible (so that if this were the rootfs, we'd be in trouble already);
initscripts would have to be smartened to first attempt mounting xfs, then, if
that failed, run xfs_repair on it and attempt mounting again afterwards.
Running xfs_repair is a bad idea because it can't replay the log.
So, long story short: ideally either the kernel should handle recovery of even
such pathologically broken filesystems, or xfs_repair should be able to replay
the log (making it safe to run on a dirty fs before mounting).
Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.