| To: | Andi Kleen <andi@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: RFC: Fix f_flags races without the BKL |
| From: | Jonathan Corbet <corbet@xxxxxxx> |
| Date: | Tue, 30 Dec 2008 05:59:56 -0700 |
| Cc: | Oleg Nesterov <oleg@xxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Andi Kleen <andi@xxxxxxxxxxxxxx>, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, bfields@xxxxxxxxxxxx, xfs-masters@xxxxxxxxxxx |
| In-reply-to: | <20081229152732.GH496@xxxxxxxxxxxxxxxxxx> |
| Organization: | LWN.net |
| References: | <20081229041352.6bbdf57c@tpl> <20081229124151.GA29634@xxxxxxxxxx> <20081229152732.GH496@xxxxxxxxxxxxxxxxxx> |
On Mon, 29 Dec 2008 16:27:32 +0100 Andi Kleen <andi@xxxxxxxxxxxxxx> wrote: > I would prefer O_LOCK_FLAGS bit too. The global lock is not very nice > and I don't doubt someone will come up with a workload which > pounds on it. Seems hard to imagine that it would be worse than the longstanding BKL situation. That said, the global lock is clearly an unsubtle approach, and people don't like it. I'd hoped to slip something quick through the merge window, but that seems unlikely, especially, since I'm allegedly on vacation. I'll forget this patch for now and revisit it next week. (Unless, of course, somebody wants to just send in the O_LOCK_FLAGS patch and be done with it. I hate to invent a new and different locking scheme for such a trivial purpose, but it's not *that* bad...) Otherwise, maybe it's worth thinking for a bit on whether it might be possible to do away with >fasync() altogether; that would make most of the problem go away. Will ponder later. jon |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: RFC: Fix f_flags races without the BKL, Jonathan Corbet |
|---|---|
| Next by Date: | Re: [xfs-masters] RFC: Fix f_flags races without the BKL, Christoph Hellwig |
| Previous by Thread: | Re: RFC: Fix f_flags races without the BKL, Andi Kleen |
| Next by Thread: | Re: [xfs-masters] RFC: Fix f_flags races without the BKL, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |