xfs-masters
[Top] [All Lists]

[Bug 803] xfs_repair 2.10.1 finds errors which it cannot repair

To: xfs-masters@xxxxxxxxxxx
Subject: [Bug 803] xfs_repair 2.10.1 finds errors which it cannot repair
From: bugzilla-daemon@xxxxxxxxxxx
Date: Fri, 5 Dec 2008 04:05:49 -0600
http://oss.sgi.com/bugzilla/show_bug.cgi?id=803


chris@xxxxxxxxxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From chris@xxxxxxxxxxxxxxxxx  2008-12-05 04:05 CST 
-------
Wow, that one line in the patch really did it!

I applied the patch, recompiled the RPM from source with

OPTIMIZER=-O1 
DEBUG=-DNDEBUG
./Makepkgs verbose

got the new RPMs (this is a *very* developer-friendly feature,
by the way - thank you!), reinstalled them, ran xfs_repair.

xfs_repair found the same incorrect nblocks as before. The output did not change
at all, even Phase 4 was identical (i.e. just printing agno after agno):

...
        - agno = 287
        - agno = 288
        - agno = 289
        - agno = 290
        - agno = 291
        - agno = 292
        - agno = 293
        - agno = 294
        - agno = 295
Phase 5 - rebuild AG headers and trees...
        - reset superblock...
Phase 6 - check inode connectivity...
        - resetting contents of realtime bitmap and summary inodes
        - traversing filesystem ...
        - traversal finished ...
        - moving disconnected inodes to lost+found ...
Phase 7 - verify and correct link counts...
done

No files were found in lost+found. When I try to access one of the files that
previously produced the error

kernel: Filesystem "sd(8,17)": corrupt dinode 1019217568, extent total = 1,
nblocks = 0.  Unmount and run xfs_repair.

etc.etc.(see previous post), now I can access, read etc. the file without any
sign of corruption.

Obviously, the filesystem was OK in the first place and the whole trouble was
created by the bug in xfs_repair - which was corrected by that one-liner patch.

I have changed the status to FIXED. I only checked 2-3 of all the affected files
so far, but I don't expect "surprises" here (should any deeper investigation in
the coming weeks bring any up, we can still reopen it).


A big THANKS to Barry for resolving this bug! :-)

Chris Karakas
http://www.karakas-online.de

PS.: BTW, that rsync problem I mentioned that triggered my using of xfs_repair
has been shown (in subsequent investigations) to be irrelevant to XFS. The
external disc is simply malfunctioning, or maybe its case (or the USB controller
in it) is defective. This "bug" has now also been fixed by buying a new shiny
external drive and case. ;-)

-- 
Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

<Prev in Thread] Current Thread [Next in Thread>