xfs-masters
[Top] [All Lists]

[xfs-masters] Re: linux-next: arm allmodconfig

To: xfs-masters@xxxxxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Dave Airlie <airlied@xxxxxxxx>, netdev@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxxxxx, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Paul Moore <paul.moore@xxxxxx>, Takashi Iwai <tiwai@xxxxxxx>, Pekka Enberg <penberg@xxxxxxxxxxxxxx>
Subject: [xfs-masters] Re: linux-next: arm allmodconfig
From: Ingo Molnar <mingo@xxxxxxx>
Date: Wed, 29 Oct 2008 09:24:59 +0100
In-reply-to: <20081029074032.GI4985@disturbed>
References: <20081028175604.81c31cea.akpm@xxxxxxxxxxxxxxxxxxxx> <20081029074032.GI4985@disturbed>
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
* Dave Chinner <david@xxxxxxxxxxxxx> wrote:

> > > fs/xfs/xfs_rtalloc.c: In function `xfs_growfs_rt':
> > > fs/xfs/xfs_rtalloc.c:1875: warning: 'tp' might be used uninitialized in 
> > > this function
> 
> False positive, and I don't get this reported, either.
> 
> Hold on - the above gcc binary only emits a warning for the 
> xfs_growfs_rt issue when CONFIG_CC_OPTIMIZE_FOR_SIZE=y is set. It 
> still doesn't catch the quota bug, though. This is so fucked up....

FYI, i've got 3 XFS warnings mapped in tip/auto-warnings-next:

 earth4:~/tip> gll linus..auto-warnings-next | grep xfs

 ec2f37c: work around warning in fs/xfs/xfs_mount.c
 8501db3: work around warning in fs/xfs/xfs_rtalloc.c
 8077af8: warnings: fix xfs posix acl

you can find those commits in the auto-warnings-next branch of -tip:

  http://people.redhat.com/mingo/tip.git/README

the rtalloc annotation is below. I went through the flow and the code 
seems to be correct and GCC is wrong.

        Ingo

------------->
<Prev in Thread] Current Thread [Next in Thread>