http://oss.sgi.com/bugzilla/show_bug.cgi?id=793
------- Additional Comments From peter@xxxxxxxxx 2008-10-03 13:28 CST -------
(In reply to comment #6)
> Argh, whoops. Ok, too quick a hack.
>
> Meanwhile, bnaujok sent an alternate patch for review:
>
> http://oss.sgi.com/archives/xfs/2008-10/msg00000.html
I just noticed that (before and after this patch), there are three separate
if() clauses with similar code and a comment that says
If the last AG is too small, reduce the filesystem size
and drop the blocks.
This patch moves one of them around, which is why I noticed. Some of them are
probably redundant, because a later if() will take care of it. I haven't tried
to trace the logic, so maybe they're not, but it looks suspicious. (I can open
a new bug for this if you want.)
--
Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
|