xfs-masters
[Top] [All Lists]

[xfs-masters] [Bug 793] mkfs: can't specify agcount with su,sw

To: xfs-master@xxxxxxxxxxx
Subject: [xfs-masters] [Bug 793] mkfs: can't specify agcount with su,sw
From: bugzilla-daemon@xxxxxxxxxxx
Date: Tue, 30 Sep 2008 12:42:14 -0700
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
http://oss.sgi.com/bugzilla/show_bug.cgi?id=793





------- Additional Comments From sandeen-xfs@xxxxxxxxxxx  2008-09-30 12:42 CST 
-------
Right now it won't adjust the agsize if you specify agcount:

                        if ((tmp_agsize >= XFS_AG_MIN_BLOCKS(blocklog)) &&
                            (tmp_agsize <= XFS_AG_MAX_BLOCKS(blocklog)) && 
                            !daflag) {
                                agsize = tmp_agsize;
                                agcount = dblocks/agsize +
                                                (dblocks % agsize != 0);

(note the !daflag)

This seems a little odd, if it's able to adjust the agsize but keep the
requested agcount then it should continue.

Or maybe if you specified the agcount it should round agsize *down* to the next
stripe unit boundary, and keep agcount - that would always fit just fine.

-Eric

-- 
Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


<Prev in Thread] Current Thread [Next in Thread>