xfs-masters
[Top] [All Lists]

[xfs-masters] [Bug 774] xfs does not handle no size change truncate.

To: xfs-master@xxxxxxxxxxx
Subject: [xfs-masters] [Bug 774] xfs does not handle no size change truncate.
From: bugzilla-daemon@xxxxxxxxxxx
Date: Thu, 24 Jan 2008 14:29:17 -0800
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
http://oss.sgi.com/bugzilla/show_bug.cgi?id=774





------- Additional Comments From dgc@xxxxxxx  2008-01-24 14:29 CST -------
<sigh>

In xfs_setattr, when doing the size change, there is this gem:

                /*
                 * Have to do this even if the file's size doesn't change.
                 */
                timeflags |= XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG;

I hate it when comments that state the bleeding obvious instead of
telling you *why* the code is doing that.

So, why do we have to do that even if the size doesn't change? the ftruncate
case (always change ctime/mtime on success) is handled by the VFS passing
down the specific flags to do this.

I suspect a hangover from Irix, because the same lines of code are in that...

More research needed.

-- 
Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


<Prev in Thread] Current Thread [Next in Thread>