| To: | xfs-masters@xxxxxxxxxxx |
|---|---|
| Subject: | [xfs-masters] Re: [PATCH] fs/xfs: remove duplicated defines |
| From: | David Chinner <dgc@xxxxxxx> |
| Date: | Wed, 14 Nov 2007 16:41:00 +1100 |
| Cc: | Eric Sandeen <sandeen@xxxxxxxxxxx>, xfs@xxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx |
| In-reply-to: | <473A619C.8040206@xxxxxxx> |
| References: | <20071111134351.106efb98@xxxxxxxxxxxxxxx> <473796EF.6050104@xxxxxxxxxxx> <473799A9.9000200@xxxxxxx> <47379E42.2030006@xxxxxxx> <47379F5A.20107@xxxxxxx> <20071112020445.GY995458@xxxxxxx> <473937AC.2080901@xxxxxxx> <20071113213013.GZ995458@xxxxxxx> <473A619C.8040206@xxxxxxx> |
| Reply-to: | xfs-masters@xxxxxxxxxxx |
| Sender: | xfs-masters-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.1i |
On Wed, Nov 14, 2007 at 01:46:52PM +1100, Timothy Shimmin wrote:
> David Chinner wrote:
> > Just replace them with (val & PAGE_CACHE_MASK)
^^^^^^^^^^^^^^^
......
> --- a/fs/xfs/linux-2.6/xfs_lrw.c 2007-11-14 13:02:46.000000000 +1100
> +++ b/fs/xfs/linux-2.6/xfs_lrw.c 2007-11-14 12:36:59.920080014 +1100
> @@ -254,9 +254,8 @@ xfs_read(
>
> if (unlikely(ioflags & IO_ISDIRECT)) {
> if (VN_CACHED(vp))
> - ret = xfs_flushinval_pages(ip,
> - ctooff(offtoct(*offset)),
> - -1, FI_REMAPF_LOCKED);
> + ret = xfs_flushinval_pages(ip, (*offset & PAGE_MASK),
^^^^^^^^^
s/PAGE_MASK/PAGE_CACHE_MASK/g
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
|
| Previous by Date: | [xfs-masters] Re: [PATCH] fs/xfs: remove duplicated defines, Timothy Shimmin |
|---|---|
| Next by Date: | [xfs-masters] [Bug 9377] 2.6.24-rc2 XFS nfsd hang, bugme-daemon |
| Previous by Thread: | [xfs-masters] Re: [PATCH] fs/xfs: remove duplicated defines, Timothy Shimmin |
| Next by Thread: | [xfs-masters] Re: [PATCH] fs/xfs: remove duplicated defines, Timothy Shimmin |
| Indexes: | [Date] [Thread] [Top] [All Lists] |