| To: | "Robert P. J. Day" <rpjday@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | [xfs-masters] Re: [PATCH] XFS: Replace remaining memclear_highpage_flush() with zero_user_page(). |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 18 Jun 2007 19:43:43 +0100 |
| Cc: | Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, xfs-masters@xxxxxxxxxxx |
| In-reply-to: | <Pine.LNX.4.64.0706181154090.26616@xxxxxxxxxxxxxxxxxxxxx> |
| Mail-followup-to: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, "Robert P. J. Day" <rpjday@xxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, xfs-masters@xxxxxxxxxxx |
| References: | <Pine.LNX.4.64.0706181154090.26616@xxxxxxxxxxxxxxxxxxxxx> |
| Reply-to: | xfs-masters@xxxxxxxxxxx |
| Sender: | xfs-masters-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.3i |
On Mon, Jun 18, 2007 at 11:59:30AM -0400, Robert P. J. Day wrote:
>
> Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
>
> ---
>
> this appears to be the final occurrence of that deprecated call in
> the entire tree which suggests that, if you're not concerned about
> out-of-tree modules, that definition could also be removed from
> include/linux/highmem.h:
>
> static inline void __deprecated memclear_highpage_flush(struct page *page,
> unsigned int offset, unsigned int size)
> {
> zero_user_page(page, offset, size, KM_USER0);
> }
Andrew, please send this and the memclear_highpage_flush removal to Linus
for 2.6.22-rc. The warning is really highly annoying and utterly pointless.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [xfs-masters] [Bug 7364] nbd dead-lock/panic with 4k stack, bugme-daemon |
|---|---|
| Next by Date: | [xfs-masters] Problems reading >1M files from same directory with nfs, Mark Seger |
| Previous by Thread: | [xfs-masters] [PATCH] XFS: Replace remaining memclear_highpage_flush() with zero_user_page()., Robert P. J. Day |
| Next by Thread: | [xfs-masters] Re: [PATCH] XFS: Replace remaining memclear_highpage_flush() with zero_user_page()., Hans-Peter Jansen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |