xfs-masters
[Top] [All Lists]

[xfs-masters] [Bug 759] New: fix parallel issue with include/ symlinks

To: xfs-master@xxxxxxxxxxx
Subject: [xfs-masters] [Bug 759] New: fix parallel issue with include/ symlinks
From: bugzilla-daemon@xxxxxxxxxxx
Date: Sun, 10 Jun 2007 21:53:08 -0700
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
http://oss.sgi.com/bugzilla/show_bug.cgi?id=759

           Summary: fix parallel issue with include/ symlinks
           Product: Linux XFS
           Version: unspecified
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: dmapi
        AssignedTo: xfs-master@xxxxxxxxxxx
        ReportedBy: vapier@xxxxxxxxxx


the include/Makefile looks like (varies slightly depending on the package):
default install :
   rm -f xfs
   $(LN_S) . xfs

which can cause problems when running in parallel since make has no way of
coordinating the phony target ("default") and the actual thing ("xfs")

if you have multiple children that execute the `rm` step followed by the `ln`
step, you could easily hit:
ln: creating symbolic link `xfs/.': File exists

some possible fixes:
 (1) create symlinks in configure script rather than makefile
 (2) use proper dependencies:
xfs:
    $(LN_S) . $@
default install : xfs
 (3) use `$(LN_S) -f` (although i think you could hit a parallel issue here in
the `ln` binary as well)

-- 
Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


<Prev in Thread] Current Thread [Next in Thread>
  • [xfs-masters] [Bug 759] New: fix parallel issue with include/ symlinks, bugzilla-daemon <=