| To: | Adrian Bunk <bunk@xxxxxxxxx> |
|---|---|
| Subject: | [xfs-masters] Re: [2.6 patch] make xfs_buftarg_list static again |
| From: | David Chinner <dgc@xxxxxxx> |
| Date: | Tue, 20 Feb 2007 11:41:38 +1100 |
| Cc: | xfs-masters@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, tes@xxxxxxx |
| In-reply-to: | <20070220000747.GC13958@xxxxxxxxx> |
| References: | <20070220000747.GC13958@xxxxxxxxx> |
| Reply-to: | xfs-masters@xxxxxxxxxxx |
| Sender: | xfs-masters-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.1i |
On Tue, Feb 20, 2007 at 01:07:47AM +0100, Adrian Bunk wrote: > xfs_buftarg_list became global for no good reason. Fallout from a much larger patch. Looks like there were a couple of STATIC -> static conversions stuffed up. Thanks for catching this, Adrian. Tim - another one for you ;) > Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx> > > --- > --- linux-2.6.20-mm2/fs/xfs/linux-2.6/xfs_buf.c.old 2007-02-18 > 22:55:40.000000000 +0100 > +++ linux-2.6.20-mm2/fs/xfs/linux-2.6/xfs_buf.c 2007-02-18 > 22:56:08.000000000 +0100 > @@ -1424,7 +1424,7 @@ > /* > * buftarg list for delwrite queue processing > */ > -LIST_HEAD(xfs_buftarg_list); > +static LIST_HEAD(xfs_buftarg_list); > static DEFINE_SPINLOCK(xfs_buftarg_lock); > > STATIC void Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [xfs-masters] [2.6 patch] make xfs_buftarg_list static again, Adrian Bunk |
|---|---|
| Next by Date: | [xfs-masters] Re: [2.6 patch] make xfs_buftarg_list static again, Timothy Shimmin |
| Previous by Thread: | [xfs-masters] [2.6 patch] make xfs_buftarg_list static again, Adrian Bunk |
| Next by Thread: | [xfs-masters] Re: [2.6 patch] make xfs_buftarg_list static again, Timothy Shimmin |
| Indexes: | [Date] [Thread] [Top] [All Lists] |