xfs-masters
[Top] [All Lists]

[xfs-masters] Re: [PATCH} XFS: Remove placeholders for unimplemented fun

To: xfs-masters@xxxxxxxxxxx
Subject: [xfs-masters] Re: [PATCH} XFS: Remove placeholders for unimplemented functionality.
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sun, 28 Jan 2007 22:58:50 -0600
Cc: Linux kernel mailing list <linux-kernel@xxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, dgc@xxxxxxx
In-reply-to: <Pine.LNX.4.64.0701281557410.11046@CPE00045a9c397f-CM001225dbafb6>
References: <Pine.LNX.4.64.0701281557410.11046@CPE00045a9c397f-CM001225dbafb6>
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
User-agent: Thunderbird 1.5.0.9 (Macintosh/20061207)
Robert P. J. Day wrote:
>   Remove a couple kernel config variables (FS_POSIX_CAP and
> FS_POSIX_MAC) that represent placeholders for unimplemented
> functionality.
> 
> Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
> 
> ---

...

> diff --git a/fs/xfs/xfs_cap.h b/fs/xfs/xfs_cap.h
> index 7a0e482..cfedfd1 100644
> --- a/fs/xfs/xfs_cap.h
> +++ b/fs/xfs/xfs_cap.h

...

> -#else
>  #define xfs_cap_vset(v,p,sz) (-EOPNOTSUPP)
>  #define xfs_cap_vget(v,p,sz) (-EOPNOTSUPP)
>  #define xfs_cap_vremove(v)   (-EOPNOTSUPP)
>  #define _CAP_EXISTS          (NULL)
> -#endif
> 
>  #endif       /* __KERNEL__ */

By the time you do this, probably may as well remove the whole file; the 
leftover 4 definitions never seem to be used.

The same may go for xfs_mac.h.

-Eric


<Prev in Thread] Current Thread [Next in Thread>