xfs-masters
[Top] [All Lists]

[xfs-masters] Re: [PATCH 18/59] sysctl: ipmi remove unnecessary insert_a

To: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
Subject: [xfs-masters] Re: [PATCH 18/59] sysctl: ipmi remove unnecessary insert_at_head flag
From: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 17 Jan 2007 14:14:54 +1100
Cc: "<Andrew Morton" <akpm@xxxxxxxx>, linux-mips@xxxxxxxxxxxxxx, linux-parport@xxxxxxxxxxxxxxxxxxx, heiko.carstens@xxxxxxxxxx, ak@xxxxxxx, linuxppc-dev@xxxxxxxxxx, paulus@xxxxxxxxx, aharkes@xxxxxxxxxx, schwidefsky@xxxxxxxxxx, tim@xxxxxxxxxxxx, rtc-linux@xxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, kurt.hackel@xxxxxxxxxx, coda@xxxxxxxxxx, vojtech@xxxxxxx, linuxsh-shmedia-dev@xxxxxxxxxxxxxxxxxxxxx, James.Bottomley@xxxxxxxxxxxx, clemens@xxxxxxxxxx, xfs@xxxxxxxxxxx, xfs-masters@xxxxxxxxxxx, andrea@xxxxxxx, openipmi-developer@xxxxxxxxxxxxxxxxxxxxx, linux-390@xxxxxxxxxxxxx, codalist@xxxxxxxxxxxxxxxxxxxxxxxx, a.zummo@xxxxxxxxxxxx, tony.luck@xxxxxxxxx, linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, aia21@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, ralf@xxxxxxxxxxxxxx, lethal@xxxxxxxxxxxx, containers@xxxxxxxxxxxxxx, linux390@xxxxxxxxxx, philb@xxxxxxx
In-reply-to: <1168965635875-git-send-email-ebiederm@xxxxxxxxxxxx>
References: <m1ac0jc4no.fsf@xxxxxxxxxxxxxxxxxxxxxxxxx> <1168965635875-git-send-email-ebiederm@xxxxxxxxxxxx>
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
On Tue, 2007-01-16 at 09:39 -0700, Eric W. Biederman wrote:
> From: Eric W. Biederman <ebiederm@xxxxxxxxxxxx> - unquoted
> 
> With unique sysctl binary numbers setting insert_at_head is pointless.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>

Acked-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>

> ---
>  drivers/char/ipmi/ipmi_poweroff.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/char/ipmi/ipmi_poweroff.c 
> b/drivers/char/ipmi/ipmi_poweroff.c
> index 9d23136..b3ae65e 100644
> --- a/drivers/char/ipmi/ipmi_poweroff.c
> +++ b/drivers/char/ipmi/ipmi_poweroff.c
> @@ -686,7 +686,7 @@ static int ipmi_poweroff_init (void)
>               printk(KERN_INFO PFX "Power cycle is enabled.\n");
>  
>  #ifdef CONFIG_PROC_FS
> -     ipmi_table_header = register_sysctl_table(ipmi_root_table, 1);
> +     ipmi_table_header = register_sysctl_table(ipmi_root_table, 0);
>       if (!ipmi_table_header) {
>               printk(KERN_ERR PFX "Unable to register powercycle sysctl\n");
>               rv = -ENOMEM;


<Prev in Thread] Current Thread [Next in Thread>