[xfs-masters] Re: [PATCH 31/59] sysctl: C99 convert the ctl_tables in arch/mips/au1000/common/power.c

[Ingo Oeser <ioe-lkml@xxxxxxxxxx>]

Hi Eric,

On Tuesday, 16. January 2007 17:39, Eric W. Biederman wrote:
> diff --git a/arch/mips/au1000/common/power.c b/arch/mips/au1000/common/power.c
> index b531ab7..31256b8 100644
> --- a/arch/mips/au1000/common/power.c
> +++ b/arch/mips/au1000/common/power.c
> @@ -419,15 +419,41 @@ static int pm_do_freq(ctl_table * ctl, int write, 
> struct file *file,

> +     {
> +             .ctl_name       = CTL_UNNUMBERED,
> +             .procname       = "suspend",
> +             .data           = NULL,
> +             .maxlen         = 0,
> +             .mode           = 0600,
> +             .proc_handler   = &pm_do_suspend
> +     },

No need for zero initialization for maxlen.

> +     {
> +             .ctl_name       = CTL_UNNUMBERED,
> +             .procname       = "sleep",
> +             .data           = NULL,
> +             .maxlen         = 0,
> +             .mode           = 0600,
> +             .proc_handler   = &pm_do_sleep
> +     },

dito

> +     {
> +             .ctl_name       = CTL_UNNUMBERED,
> +             .procname       = "freq",
> +             .data           = NULL,
> +             .maxlen         = 0,
> +             .mode           = 0600,
> +             .proc_handler   = &pm_do_freq
> +     },
> +     {}
>  };

dito

Regards

Ingo Oeser