xfs-masters
[Top] [All Lists]

[xfs-masters] [PATCH 54/59] sysctl: Remove support for directory strateg

To: "<Andrew Morton" <akpm@xxxxxxxx>
Subject: [xfs-masters] [PATCH 54/59] sysctl: Remove support for directory strategy routines.
From: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
Date: Tue, 16 Jan 2007 09:39:59 -0700
Cc: <linux-kernel@xxxxxxxxxxxxxxx>, <containers@xxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, xfs-masters@xxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, James.Bottomley@xxxxxxxxxxxx, minyard@xxxxxxx, openipmi-developer@xxxxxxxxxxxxxxxxxxxxx, <tony.luck@xxxxxxxxx>, linux-mips@xxxxxxxxxxxxxx, ralf@xxxxxxxxxxxxxx, schwidefsky@xxxxxxxxxx, heiko.carstens@xxxxxxxxxx, linux390@xxxxxxxxxx, linux-390@xxxxxxxxxxxxx, paulus@xxxxxxxxx, linuxppc-dev@xxxxxxxxxx, lethal@xxxxxxxxxxxx, linuxsh-shmedia-dev@xxxxxxxxxxxxxxxxxxxxx, <ak@xxxxxxx>, vojtech@xxxxxxx, clemens@xxxxxxxxxx, a.zummo@xxxxxxxxxxxx, rtc-linux@xxxxxxxxxxxxxxxx, linux-parport@xxxxxxxxxxxxxxxxxxx, andrea@xxxxxxx, tim@xxxxxxxxxxxx, philb@xxxxxxx, aharkes@xxxxxxxxxx, coda@xxxxxxxxxx, codalist@xxxxxxxxxxxxxxxxxxxxxxxx, aia21@xxxxxxxxxx, linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx, mark.fasheh@xxxxxxxxxx, kurt.hackel@xxxxxxxxxx, "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
In-reply-to: <m1ac0jc4no.fsf@xxxxxxxxxxxxxxxxxxxxxxxxx>
References: <m1ac0jc4no.fsf@xxxxxxxxxxxxxxxxxxxxxxxxx>
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
From: Eric W. Biederman <ebiederm@xxxxxxxxxxxx> - unquoted

parse_table has support for calling a strategy routine
when descending into a directory.  To date no one has
used this functionality and the /proc/sys interface has
no analog to it.

So no one is using this functionality kill it and make
the binary sysctl code easier to follow.

Signed-off-by: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
---
 kernel/sysctl.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index e655b11..2c3703d 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -1171,14 +1171,6 @@ repeat:
                        if (table->child) {
                                if (ctl_perm(table, 001))
                                        return -EPERM;
-                               if (table->strategy) {
-                                       error = table->strategy(
-                                               table, name, nlen,
-                                               oldval, oldlenp,
-                                               newval, newlen);
-                                       if (error)
-                                               return error;
-                               }
                                name++;
                                nlen--;
                                table = table->child;
-- 
1.4.4.1.g278f


<Prev in Thread] Current Thread [Next in Thread>