[xfs-masters] Re: [PATCH 5 of 11] XFS: Use SEEK_{SET, CUR, END} instead of hardcoded values

[David Howells <dhowells@xxxxxxxxxx>]

David Chinner <dgc@xxxxxxx> wrote:

> The hard coded values  used in xfs_change_file_space() are documented as part
> of the API to the userspace functions that use this interface in xfsctl(3).

Hmmm... that's a good point.  I think you're right on this account, and so the
comments in:

                case 0: /*SEEK_SET*/
                        break;
                case 1: /*SEEK_CUR*/
                        bf->l_start += offset;
                        break;
                case 2: /*SEEK_END*/
                        bf->l_start += ip->i_d.di_size;
                        break;

should be stripped off as they are not exactly correct.

David