xfs-masters
[Top] [All Lists]

[xfs-masters] Re: [PATCH 2.6.18-rc4-mm3 2/2] fs/xfs: Converting into gen

To: Richard Knutsson <ricknu-0@xxxxxxxxxxxxxx>
Subject: [xfs-masters] Re: [PATCH 2.6.18-rc4-mm3 2/2] fs/xfs: Converting into generic boolean
From: Nathan Scott <nathans@xxxxxxx>
Date: Mon, 4 Sep 2006 15:02:41 +1000
Cc: akpm@xxxxxxxx, xfs-masters@xxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <44F833C9.1000208@xxxxxxxxxxxxxx>; from ricknu-0@xxxxxxxxxxxxxx on Fri, Sep 01, 2006 at 03:21:13PM +0200
References: <44F833C9.1000208@xxxxxxxxxxxxxx>
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
On Fri, Sep 01, 2006 at 03:21:13PM +0200, Richard Knutsson wrote:
> From: Richard Knutsson <ricknu-0@xxxxxxxxxxxxxx>
> 
> Converting:
> 'B_FALSE' into 'false'
> 'B_TRUE'  into 'true'
> 'boolean_t' into 'bool'

Hmm, so your bool is better than the next guys bool[ean[_t]]? :)

Seems like it'll be a few more days until the next cleanup patch
to remove _that_, so we shouldn't go that path.  Since we do use
the current boolean_t somewhat inconsistently in XFS, I'd say we
should just toss the thing and use int.

I took the earlier patch and completed it, switching over to int
use in place of boolean_t in the few places it used - I'll merge
that at some point, when its had enough testing.

cheers.

-- 
Nathan


<Prev in Thread] Current Thread [Next in Thread>