| To: | Richard Knutsson <ricknu-0@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | [xfs-masters] Re: [PATCH 2.6.18-rc4-mm3 2/2] fs/xfs: Correcting error-prone boolean-statement |
| From: | Nathan Scott <nathans@xxxxxxx> |
| Date: | Fri, 1 Sep 2006 10:07:45 +1000 |
| Cc: | akpm@xxxxxxxx, xfs-masters@xxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx |
| In-reply-to: | <44F77653.6000606@xxxxxxxxxxxxxx>; from ricknu-0@xxxxxxxxxxxxxx on Fri, Sep 01, 2006 at 01:52:51AM +0200 |
| References: | <44F77653.6000606@xxxxxxxxxxxxxx> |
| Reply-to: | xfs-masters@xxxxxxxxxxx |
| Sender: | xfs-masters-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.2.5i |
On Fri, Sep 01, 2006 at 01:52:51AM +0200, Richard Knutsson wrote: > From: Richard Knutsson <ricknu-0@xxxxxxxxxxxxxx> > > Converting error-prone statement: > "if (var == B_FALSE)" into "if (!var)" > "if (var == B_TRUE)" into "if (var)" This is my preference too, rather than the local boolean usage which isn't used with any consistency... but: > Compile-tested Are you using XFS on your systems? What is your strategy for getting this runtime tested going to be? Or are you delegating that responsibility? :) cheers. -- Nathan |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [xfs-masters] BMW International program, mrsteresacole |
|---|---|
| Next by Date: | [xfs-masters] [PATCH 2.6.18-rc4-mm3 2/2] fs/xfs: Correcting error-prone boolean-statement, Richard Knutsson |
| Previous by Thread: | [xfs-masters] [PATCH 2.6.18-rc4-mm3 2/2] fs/xfs: Correcting error-prone boolean-statement, Richard Knutsson |
| Next by Thread: | [xfs-masters] Re: [PATCH 2.6.18-rc4-mm3 2/2] fs/xfs: Correcting error-prone boolean-statement, Richard Knutsson |
| Indexes: | [Date] [Thread] [Top] [All Lists] |