| To: | Jesper Juhl <jesper.juhl@xxxxxxxxx> |
|---|---|
| Subject: | [xfs-masters] Re: [PATCH] XFS: remove pointless conditional testing 'nmp' vs NULL in fs/xfs/xfs_rtalloc.c::xfs_growfs_rt() |
| From: | Nathan Scott <nathans@xxxxxxx> |
| Date: | Thu, 17 Aug 2006 16:31:10 +1000 |
| Cc: | linux-kernel@xxxxxxxxxxxxxxx, xfs-masters@xxxxxxxxxxx, xfs@xxxxxxxxxxx |
| In-reply-to: | <200608162244.19957.jesper.juhl@xxxxxxxxx>; from jesper.juhl@xxxxxxxxx on Wed, Aug 16, 2006 at 10:44:19PM +0200 |
| References: | <200608130016.51136.jesper.juhl@xxxxxxxxx> <20060814110942.C2698880@xxxxxxxxxxxxxxxxxxxxxxxx> <9a8748490608140025w3257f315jcceccf05d200437f@xxxxxxxxxxxxxx> <200608162244.19957.jesper.juhl@xxxxxxxxx> |
| Reply-to: | xfs-masters@xxxxxxxxxxx |
| Sender: | xfs-masters-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.2.5i |
On Wed, Aug 16, 2006 at 10:44:19PM +0200, Jesper Juhl wrote: > On Monday 14 August 2006 09:25, Jesper Juhl wrote: > > On 14/08/06, Nathan Scott <nathans@xxxxxxx> wrote: > > > On Sun, Aug 13, 2006 at 12:16:50AM +0200, Jesper Juhl wrote: > > > > > > > This patch gets rid of the pointless check. > > > > > > Hmm, seems like code churn that makes the code slightly less > > > obvious, but thats just me... I'd prefer a tested patch that > > > implements the above suggestion, to be honest. :) > > > > > Ok, I'll see what I can come up with. > > > > How this? > > Compile tested only since I'm at home and don't have any XFS filesystems to > play with atm. It looks good. I've tested it, and it works fine - I'll merge it into my tree shortly. Thanks for following up on this. cheers. -- Nathan |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [xfs-masters] [RFC][PATCH 0/8] [RFC][PATCH 0/8] Removal of old code, Michal Piotrowski |
|---|---|
| Next by Date: | [xfs-masters] [Bug 6957] Oops with fil with holes, bugme-daemon |
| Previous by Thread: | [xfs-masters] Re: [PATCH] XFS: remove pointless conditional testing 'nmp' vs NULL in fs/xfs/xfs_rtalloc.c::xfs_growfs_rt(), Jesper Juhl |
| Next by Thread: | [xfs-masters] Re: [PATCH] XFS: possibly uninitialized variable use in fs/xfs/xfs_da_btree.c::xfs_da_node_lookup_int(), Nathan Scott |
| Indexes: | [Date] [Thread] [Top] [All Lists] |