xfs-masters
[Top] [All Lists]

[xfs-masters] [Bug 711] on IDE Systems without barrier support XFS crash

To: xfs-master@xxxxxxxxxxx
Subject: [xfs-masters] [Bug 711] on IDE Systems without barrier support XFS crashes
From: bugzilla-daemon@xxxxxxxxxxx
Date: Thu, 27 Jul 2006 04:33:23 -0700
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
http://oss.sgi.com/bugzilla/show_bug.cgi?id=711





------- Additional Comments From stefan@xxxxxxxxx  2006-07-27 04:33 CST -------
Hi!

This crash only occurs if you use quota and IDE without barrier support.

The Problem is, that on a new mount of a root filesystem - the flag VFS_RDONLY 
is set - and so no barrier check is done before checking quota. With this 
patch barrier check is done always. The partition should not be mounted at 
that moment. For mount -o remount, rw or something like this it uses another 
function where VFS_RDONLY is checked.

Here is my patch:
*** fs/xfs/xfs_vfsops.c.orig    Thu Jul 27 13:10:23 2006
--- fs/xfs/xfs_vfsops.c Thu Jul 27 13:11:17 2006
*************** xfs_mount(
*** 524,528 ****
                goto error2;
  
!       if ((mp->m_flags & XFS_MOUNT_BARRIER) && !(vfsp->vfs_flag & 
VFS_RDONLY))
                xfs_mountfs_check_barriers(mp);
  
--- 524,528 ----
                goto error2;
  
!       if (mp->m_flags & XFS_MOUNT_BARRIER)
                xfs_mountfs_check_barriers(mp);


-- 
Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


<Prev in Thread] Current Thread [Next in Thread>
  • [xfs-masters] [Bug 711] on IDE Systems without barrier support XFS crashes, bugzilla-daemon <=