http://oss.sgi.com/bugzilla/show_bug.cgi?id=704
------- Additional Comments From acorliss@xxxxxxxxxxxxxxxx 2006-07-21 08:16
CST -------
(In reply to comment #8)
> Looks good to me. In the end, what is really needed is a pagesized
> buffer, I think. So maybe doing that rather than hardcoding a number might
> be better, or at least an assertion that sizeof(buf) >= pagesize, to keep this
> from cropping up again.
>
> -Eric
Right now your minimum read is 8K, and I'm not sure what the historical need was
for that, nor why you'd still be checking that in addition to buf+pagesize and
buf+4096. Ideally, I think you're right, the buffer should be based on
pagesize.
--
Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
|