| To: | "'David Chinner'" <dgc@xxxxxxx>, "'Adrian Bunk'" <bunk@xxxxxxxxx> |
|---|---|
| Subject: | [xfs-masters] Re: fs/xfs/xfs_vnodeops.c:xfs_readdir(): NULL variable dereferenced |
| From: | "Hua Zhong" <hzhong@xxxxxxxxx> |
| Date: | Thu, 6 Jul 2006 16:37:59 -0700 |
| Cc: | <xfs-masters@xxxxxxxxxxx>, <xfs@xxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx> |
| Domainkey-signature: | a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:from:to:cc:subject:date:message-id:mime-version:content-type:content-transfer-encoding:x-mailer:in-reply-to:x-mimeole:thread-index; b=kf7/9QQjYiVd6gtz7Xf/7Ui1BtimJ0YESUwpIVUaVfDDS3V5l2yF1gN1oSVww55l7/OmRaQc1djJz/bzUn0otxb2TsMWBiFkz1oy9BWfjPGSM7FuDmetCYMXHkEQGp+s4J3bhI1CmNk52D2nxbHE2cTX1TZ3DXCbnE9wObyAFgw= |
| In-reply-to: | <20060706233246.GB15160733@xxxxxxxxxxxxxxxxx> |
| Reply-to: | xfs-masters@xxxxxxxxxxx |
| Sender: | xfs-masters-bounce@xxxxxxxxxxx |
| Thread-index: | AcahVNRubWi/afgCTO6VGw+OjnLzTAAACwtg |
> > <-- snip --> > > > > Note that tp is never assigned any value other than NULL (and the > > Coverity checker found a way how tp might be dereferenced four > > function calls later). > > Then the bug is probably in the function call that uses tp > without first checking whether it's null. Can you tell us > where that dereference occurs? > > Cheers, > > Dave. Maybe, but the above code is confusing too. Why not get rid of tp and explicitly pass NULL as "xfs_dir_getdents(NULL, dp, uiop, eofp);"? Hua |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [xfs-masters] fs/xfs/xfs_vnodeops.c:xfs_readdir(): NULL variable dereferenced, Adrian Bunk |
|---|---|
| Next by Date: | [xfs-masters] Re: fs/xfs/xfs_vnodeops.c:xfs_readdir(): NULL variable dereferenced, Adrian Bunk |
| Previous by Thread: | [xfs-masters] fs/xfs/xfs_vnodeops.c:xfs_readdir(): NULL variable dereferenced, Adrian Bunk |
| Next by Thread: | [xfs-masters] Get back to us as soon as possible, Russ Andy |
| Indexes: | [Date] [Thread] [Top] [All Lists] |