xfs-masters
[Top] [All Lists]

[xfs-masters] [Bug 6757] repeated slight XFS corruption

To: xfs-masters@xxxxxxxxxxx
Subject: [xfs-masters] [Bug 6757] repeated slight XFS corruption
From: bugme-daemon@xxxxxxxxxxxxxxxxxxx
Date: Thu, 29 Jun 2006 01:31:53 -0700
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
http://bugzilla.kernel.org/show_bug.cgi?id=6757





------- Additional Comments From Martin@xxxxxxxxxxxx  2006-06-29 01:30 -------
Created an attachment (id=8452)
 --> (http://bugzilla.kernel.org/attachment.cgi?id=8452&action=view)
patch that might fix the issue

I am currently testing a patch that Nathan Scott sent to the stable kernel team
and apparently CCd to me. From what I understand this patch may fix the issue I
am seeing.

For now all seems fine, but its too early to say anything definite.

Here is that patch including description of what it does:

Fix nused counter.  It's currently getting set to -1 rather than getting
decremented by 1.  Since nused never reaches 0, the "if (!free->hdr.nused)"
check in xfs_dir2_leafn_remove() fails every time and xfs_dir2_shrink_inode()
doesn't get called when it should.  This causes extra blocks to be left on
an empty directory and the directory in unable to be converted back to
inline extent mode.

Signed-off-by: Mandy Kirkconnell <alkirkco@xxxxxxx>
Signed-off-by: Nathan Scott <nathans@xxxxxxx>

--- a/fs/xfs/xfs_dir2_node.c    2006-06-28 08:20:56.000000000 +1000
+++ b/fs/xfs/xfs_dir2_node.c    2006-06-28 08:20:56.000000000 +1000
@@ -972,7 +972,7 @@ xfs_dir2_leafn_remove(
                        /*
                         * One less used entry in the free table.
                         */
-                       free->hdr.nused = cpu_to_be32(-1);
+                       be32_add(&free->hdr.nused, -1);
                        xfs_dir2_free_log_header(tp, fbp);
                        /*
                         * If this was the last entry in the table, we can

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


<Prev in Thread] Current Thread [Next in Thread>