xfs-masters
[Top] [All Lists]

[xfs-masters] Re: Linux 2.6.17-rc2 - notifier chain problem?

To: sekharan@xxxxxxxxxx
Subject: [xfs-masters] Re: Linux 2.6.17-rc2 - notifier chain problem?
From: Andrew Morton <akpm@xxxxxxxx>
Date: Fri, 28 Apr 2006 16:23:02 -0700
Cc: torvalds@xxxxxxxx, ashok.raj@xxxxxxxxx, stern@xxxxxxxxxxxxxxxxxxx, herbert@xxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxx, xfs-masters@xxxxxxxxxxx
In-reply-to: <1146265920.7063.133.camel@linuxchandra>
References: <Pine.LNX.4.44L0.0604261144010.6376-100000@xxxxxxxxxxxxxxxxxxxx> <1146075534.24650.11.camel@linuxchandra> <20060426114348.51e8e978.akpm@xxxxxxxx> <20060426122926.A31482@xxxxxxxxxxxxxxxxxxxx> <1146082893.24650.27.camel@linuxchandra> <20060426132644.A31761@xxxxxxxxxxxxxxxxxxxx> <1146265920.7063.133.camel@linuxchandra>
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
Chandra Seetharaman <sekharan@xxxxxxxxxx> wrote:
>
> Looks like the patches I provided is a step backward from where Ashok &
> Andrew were taking the register_cpu_notifier stuff to.
> 
> After some discussions with Ashok we both think the following would be
> the right direction:
>       1 revert the changes i pushed recently
>       2 make all usages of register_cpu_notifier to be _init and 
>           __initdata (if hotplug cpu is defined these are removed)
>       3 export the symbols register_cpu_notifier and
>           unregister_cpu_notifier only in CONFIG_HOTPLUG_CPU is defined
>       4 move the hot plug cpu based usages of register_cpu_notifier
>         inside #ifdef CONFIG_HOTPLUF_CPU(like xfs's usage).
> 
> I have few questions:
>  - any problems with the above direction (mainly 3) ?
>  - Should we proceed in this direction ?
>  - is it too late for 2.6.17 ? if not late how much time do we have ?

hm.  I'm leaning more towards doing something expedient and obvious for
2.6.17.  It's pretty late in the cycle, and the only downside is the loss
of a kbyte or two.  Plus I'll be at linuxtag next week and won't be around to
help out.

So if it's OK, can we do something minimal, revisit it after 2.6.17?


<Prev in Thread] Current Thread [Next in Thread>