[Top] [All Lists]

[xfs-masters] Re: Linux 2.6.17-rc2 - notifier chain problem?

To: sekharan@xxxxxxxxxx
Subject: [xfs-masters] Re: Linux 2.6.17-rc2 - notifier chain problem?
From: Andrew Morton <akpm@xxxxxxxx>
Date: Wed, 26 Apr 2006 11:43:48 -0700
Cc: stern@xxxxxxxxxxxxxxxxxxx, herbert@xxxxxxxxxxxx, torvalds@xxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxx, xfs-masters@xxxxxxxxxxx, ashok.raj@xxxxxxxxx
In-reply-to: <1146075534.24650.11.camel@linuxchandra>
References: <Pine.LNX.4.44L0.0604261144010.6376-100000@xxxxxxxxxxxxxxxxxxxx> <1146075534.24650.11.camel@linuxchandra>
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
Chandra Seetharaman <sekharan@xxxxxxxxxx> wrote:
> On Wed, 2006-04-26 at 11:49 -0400, Alan Stern wrote:
> > On Mon, 24 Apr 2006, Andrew Morton wrote:
> <snip>
> > > I guess for now, bringing those things into .text and .data when there's
> > > doubt is a reasonable thing to do.
> > 
> > It seems clear that this particular oops was caused by the xfs driver 
> > trying to register a cpu_notifier at a time when that notifier chain was 
> > expected to be completely idle.
> > 
> > Instead of moving all this code and data out of the init sections, 
> > wouldn't it be better to fix the individual drivers (like xfs) so they 
> > won't try to use inaccessible notifier chains?
> > 
> > For that matter, if lots of entries on the cpu_notifier chain are marked 
> > with __cpuinit, then shouldn't the chain header itself plus 
> > register_cpu_notifier and unregister_cpu_notifier be marked the same way?
> Your suggestion is very valid, since the cpu_notifiers are called only
> at init time, unless CONFIG_HOTPLUG_CPU is turned ON. Definitions of
> __cpuinit and __cpuinitdata takes care of HOTPLUG config option.
> XFS wants to register only for HOTPLUG_CPU case, and it do so by putting
> the callback, register and unregister inside #ifdef HOTPLUG_CPU.
> Note: I made the changes and tested, it works.
> Andrew, Linus, Any comments ?

Ashok's the one who has spent most time with this.  Basically _everything_
to do with register_cpu_notifier() and all the things which call it should
be __cpuinit and should be tossed away during boot on non-cpu-hotplug

But there are a few nasty problems with that which made us give up.

<Prev in Thread] Current Thread [Next in Thread>