| To: | xfs-masters@xxxxxxxxxxx |
|---|---|
| Subject: | [xfs-masters] Re: [2.6 patch] fs/xfs/: possible cleanups |
| From: | Christoph Hellwig <hch@xxxxxx> |
| Date: | Mon, 31 Oct 2005 00:28:17 +0100 |
| Cc: | nathans@xxxxxxx, linux-xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx |
| In-reply-to: | <20051030200242.GK4180@xxxxxxxxx> |
| References: | <20051030200242.GK4180@xxxxxxxxx> |
| Reply-to: | xfs-masters@xxxxxxxxxxx |
| Sender: | xfs-masters-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.3.28i |
On Sun, Oct 30, 2005 at 09:02:42PM +0100, Adrian Bunk wrote: > This patch contains the following possible cleanups: > - make needlessly global functions static > - xfs_trans_item.c should #include "xfs_trans_priv.h" for getting the > prototypes of it's global functions. > > Please review which of these changes do make sense. I applied the things from your last patch that we could apply, but some symbols can't be made static because the parts of codebase are shared with userland and Linux 2.4 where they need to be global. I'll go through this patch again and will apply the parts that we can do - there seems to be lots of new stuff vs last time. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [xfs-masters] d1scount cials-tabs, Diann Zimmerman |
|---|---|
| Next by Date: | [xfs-masters] 新着メール, 美奈子 |
| Previous by Thread: | [xfs-masters] [2.6 patch] fs/xfs/: possible cleanups, Adrian Bunk |
| Next by Thread: | [xfs-masters] Your Bank of Oklahoma Account could be Suspended, Bank of Oklahoma Security Validation |
| Indexes: | [Date] [Thread] [Top] [All Lists] |