xfs-masters
[Top] [All Lists]

[xfs-masters] Re: [-mm PATCH 2/32] fs: fix-up schedule_timeout() usage

To: Nishanth Aravamudan <nacc@xxxxxxxxxx>
Subject: [xfs-masters] Re: [-mm PATCH 2/32] fs: fix-up schedule_timeout() usage
From: Christoph Hellwig <hch@xxxxxx>
Date: Mon, 15 Aug 2005 22:36:20 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, xfs-masters@xxxxxxxxxxx, sfrench@xxxxxxxxx, sct@xxxxxxxxxx, okir@xxxxxxxxxxxxxxxxxxxx, trond.myklebust@xxxxxxxxxx, reiserfs-dev@xxxxxxxxxxx, urban@xxxxxxxxxxxxxxx, nathans@xxxxxxx, akpm@xxxxxxxx, samba-technical@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, reiserfs-list@xxxxxxxxxxx, samba@xxxxxxxxx, linux-xfs@xxxxxxxxxxx
In-reply-to: <20050815184013.GJ2854@xxxxxxxxxx>
References: <20050815180514.GC2854@xxxxxxxxxx> <20050815180804.GE2854@xxxxxxxxxx> <20050815181752.GA23701@xxxxxx> <20050815184013.GJ2854@xxxxxxxxxx>
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Mon, Aug 15, 2005 at 11:40:13AM -0700, Nishanth Aravamudan wrote:
> Hrm, I got dropped from the Cc list...? No worries, I'm subscribed in
> two places :)

I didn't do that manually, must haven some mail header thing.

> I think your reference to "last time" is the KJ patches which probably
> used msleep{,_interruptible}() instead of schedule_timeout(). This
> patchset, in contrast, should result in *no* functional changes (beyond
> some more precisie conversions, where appropriate).
> schedule_timeout_interruptible(some_value), for instance is nothing more than:
> 
>       set_current_state(TASK_INTERRUPTIBLE);
>       schedule_timeout(some_value);
> 
> Just in the form of a combine function call. No loops like msleep() &
> co.
> 
> Is the patch still a problem?

No, it's fine.  Sorry for the noise.


<Prev in Thread] Current Thread [Next in Thread>