[xfs-masters] Re: [2.6 patch] fs/xfs/: possible cleanups

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Fri, May 13, 2005 at 02:47:21AM +0200, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - make needlessly global code static
> - remove the obsolete support/qsort.c
> - debug.c: remove the read-only global variable doass
>            (replaced by a #define)
> - #if 0 the following unused global functions:
>   - quota/xfs_dquot.c: xfs_qm_dqwarn
>   - xfs_bmap_btree.c: xfs_bmbt_lookup_le
>   - xfs_fsops.c: xfs_fs_log_dummy
>   - xfs_inode.c: xfs_inobp_bwcheck
>   - xfs_trans.c: xfs_trans_callback
>   - xfs_trans_inode.c: xfs_trans_ihold_release
> 
> Please check which of these changes do make sense.

I'll take care of getting this patch into the XFS tree.  Hopefully
we can just remove the unused global functions, but I'll have to check
first whether they might be used by the userland tools.