xfs-masters
[Top] [All Lists]

[xfs-masters] Re: [2.6 patch] let 4KSTACKS depend on EXPERIMENTAL and XF

To: Adrian Bunk <bunk@xxxxxxxxx>
Subject: [xfs-masters] Re: [2.6 patch] let 4KSTACKS depend on EXPERIMENTAL and XFS on 4KSTACKS=n
From: Chris Wedgwood <cw@xxxxxxxx>
Date: Tue, 20 Jul 2004 13:42:38 -0700
Cc: "Jeffrey E. Hundstad" <jeffrey.hundstad@xxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, Steve Lord <lord@xxxxxxx>, linux-xfs@xxxxxxxxxxx, xfs-masters@xxxxxxxxxxx, nathans@xxxxxxx, Cahya Wirawan <cwirawan@xxxxxxxxxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20040720195012.GN14733@xxxxxxxxx>
References: <20040720114418.GH21918@xxxxxxxxxxxxxxxxxxxxxxxxxx> <40FD0A61.1040503@xxxxxxx> <40FD2E99.20707@xxxxxxxx> <20040720195012.GN14733@xxxxxxxxx>
Reply-to: xfs-masters@xxxxxxxxxxx
Sender: xfs-masters-bounce@xxxxxxxxxxx
On Tue, Jul 20, 2004 at 09:50:12PM +0200, Adrian Bunk wrote:

> 1. let 4KSTACKS depend on EXPERIMENTAL

i don't like this change, despite what i might have claimed earlier :)

the reason i say this is if XFS blows up with 4K stacks then it
probably can with 8K stacks but it will be much harder, so it's not
really fixing anything but just papering over the problem

the reason for this is 8K stacks means you don't have separate irq
stacks, so if and interrupt comes along at the right time and the
codes paths are just right, you can still overflow (arguably you have
less overall space than with 4K stacks and separate irq stacks)

that said, separate irq stacks *and* 8k thread stacks would be safe,
but i'd love to see ideas on how to get the stack utilization down
(it's actually really hard)


  --cw

<Prev in Thread] Current Thread [Next in Thread>