Changes committed to git://git.pcp.io/kenj/pcp master
Ken McDonell (4):
src/pmcd/pmdaproc.sh: tweak signal sending logic
qa/964: add some diagnostics to $seq.full
src/libpcp/src/optfetch.c: changes to diagnostics
src/libpcp/src/pdu.c: add assert() for pduread()
qa/964 | 5 ++++-
src/libpcp/src/optfetch.c | 44 ++++++++++++++++++++++++++++----------------
src/libpcp/src/pdu.c | 7 +++++++
src/pmcd/pmdaproc.sh | 17 ++++++++++++++---
4 files changed, 53 insertions(+), 20 deletions(-)
Details ...
commit 4011f44baec30e055aeda72b2f07e05d7c2756bd
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Nov 2 10:13:05 2016 +1100
src/libpcp/src/pdu.c: add assert() for pduread()
To help isolate some recent problems (with pmlogger in particular),
we'll abort now if pduread() is called with a file descriptor <0 ...
this should never happen if the world is on good shape.
commit 2ce8f897767469bdcc4a2fec46146ce74a5a47c9
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Nov 2 10:10:03 2016 +1100
src/libpcp/src/optfetch.c: changes to diagnostics
Previous diagnostics were guarded by #ifdef DESPERATE which is really
not too useful.
Changed this to run-time guarding requiring -Doptfetch and -Ddesperate.
Also added some diagnostics for __pmOptFetchDel() that apparently missed
the diagnostics boat when it first sailed.
commit 3d612b531436528b4197917265de8ae03b794353
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Nov 2 10:09:09 2016 +1100
qa/964: add some diagnostics to $seq.full
Trying to track down a "sometimes on some hosts" failure.
commit 20b38628d639436582a51aff4206cab71ee45d6c
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Nov 2 10:02:48 2016 +1100
src/pmcd/pmdaproc.sh: tweak signal sending logic
Nathan's last change made delivery of SIGHUP more robust.
Unfortunately it widened the window between pmcd getting the SIGHUP
and pmcd doing the post-SIGHUP work (this is delayed in pmcd so it does
not run in a signal handler, i.e. interrupt, context). This increased
the chance that the PMDA install script would fail to find the recently
installed PMDA's metrics because pmcd had not yet finished its work.
After the loop checking for the delivery of the SIGHUP, re-instate
a pmsleep $signal_delay to compensate, and this has the side-effect
that it can be over-ridden from the PMDA's Install script if needs be
(which reverts to the former behaviour).
|