On 10/07/2016 03:06 AM, Nathan Scott wrote:
Hi Dave,
----- Original Message -----
This is my first Qt creation using the qt designer tool. A review of all
aspects is definitely warranted.
Nice! Getting there - handful of things I came across trying it ...
Thanks for the review.
- there's a UI interaction "surprise" when clicking on a chart, while
multiple charts active (e.g. pmchart -c CPU -c Netbytes) - it pops up
multiple dialogs at once. Should always only be one - the clicked-on
chart's metrics.
Yeah -- I knew about this and thought that maybe folks would decide it
was a good thing(tm). I'll see what I can do. It looks like all charts
get the 'selected' signal when any one of them is selected.
- should be using a QDialog here rather than a new QMainWindow I think
(allows dialog-OK button, which we also need here) - we don't need the
menu bar, status bar, etc of a QMainWindow in a QDialog;
OK -- makes sense. I'll integrate your patch for this.
- (re-)sizing of dialogs I always find tricky, and when I resize this
one, everything stays "static" - ideally the widgets would all resize
with the dialog window. Have a look at the way saveviewdialog.ui does
this, e.g. when clicking+dragging on the window-manager-window see how
everything reshapes.
I did look into resizing. It turns out that QTableWidget only supports
resizing of the left-most column and the bottom-most row, which looked
funny to me. I can change it back to doing that and see what folks think.
Attached patch switched to using QDialog, adds an OK button, and sets
up the table headings in the .ui file ... but breaks a bunch too. And
I'm not sure how to get the resizing working correctly like we have in
saveviewdialog.ui - maybe you can see what I've missed there? (also,
in designer you can use Ctrl+r - Run - to quickly test any changes to
a new window, if you hadn't found that already).
I'll have a look. Thanks.
Dave
|