Changes committed to git://git.pcp.io/pcp.git master
Nathan Scott (3):
qa: couple of small improvements for running tests in containers
pmchart: stacked bar charts need same scaling as utilization
qa: tweak pmrep test 1069 to build and use [test] config
Marko Myllynen (2):
pmrep: add support for specifying instances
pmrep: better handling of global variable
qa/1069 | 31 +++++++++++++--
qa/1069.out | 61 +++++++++++++++++++++++++++--
qa/255 | 1
qa/933 | 2
qa/common.check | 9 ++++
src/bashrc/pcp_completion.sh | 2
src/pmchart/sampling.cpp | 3 -
src/pmrep/TODO | 6 +-
src/pmrep/pmrep.1 | 65 +++++++++++++++++++++++++++++--
src/pmrep/pmrep.conf | 1
src/pmrep/pmrep.conf.5 | 10 ++++
src/pmrep/pmrep.py | 88 ++++++++++++++++++++++++++++++++++++++++---
src/zshrc/_pcp | 3 -
13 files changed, 255 insertions(+), 27 deletions(-)
commit 5ce32578c165ea065026eec38b075f24f2cafd50
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Mon Oct 10 12:35:33 2016 +1100
qa: tweak pmrep test 1069 to build and use [test] config
As nature intended, I think ... looks like a patch snippet
may have been lost somewhere, but test fails without this.
commit c473c545e858922dd5ab1eb29e39410547da146d
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Mon Oct 10 11:43:19 2016 +1100
pmrep: better handling of global variable
Clear the global variable before, not after, using it, much better.
commit 9a3bc1b75bfaa5e60c57693f24b1c130b7059f4f
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Mon Oct 10 11:42:09 2016 +1100
pmrep: add support for specifying instances
Specifying instances to report is hugely helpful with many metrics, the
best example is probably proc.* metrics where there's lots of instances
and the user might be interested in only one or two of them.
This commit adds support to pmrep(1) for specifying the instances to
report, either using a globally defined list or instances per metric.
The implementation is relatively straightforward, a bit of gymnastics
needed to parse the command line vs config file right and to pass more
than one parameter to pmTraversePMNS().
QA updated with lots of tests, all current and new QA passing, shell
completions updated while at it, man pages updated as well.
There are two things that might require further thought:
1) Instance specification can actually be a regex but I'm not yet 100%
sure it's a good idea so for now I've left it undocumented, I think
it's best we gather a bit of experience and then either document it or
remove the regex support.
2) Reporting to archive ignore this in the spirit of pmlogger(1) but it
might make sense to respect the instance specification with archives as
well. There's been some discussion about this wrt pmlogger earlier,
perhaps we could try to find a common consensus for both:
https://bugzilla.redhat.com/show_bug.cgi?id=1345821
commit e49a20b7bd34b4893dc194e8d373595164c300bd
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Fri Oct 7 11:40:09 2016 +1100
pmchart: stacked bar charts need same scaling as utilization
commit 65aac10155cfd94039023e09bc5d7ea6eba976a3
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Fri Oct 7 08:53:03 2016 +1100
qa: couple of small improvements for running tests in containers
|