Mark,
I'll leave it to you to decide if this should be pulled into the next release
at this late stage, but the earlier changes to /etc/pcp.env are wrong on
several levels and in many places.
With these changes I have a clean qa run on Ubuntu 16.04 and I'm about to fire
up a couple of other qa runs.
Changes committed to git://git.pcp.io/kenj/pcp master
Ken McDonell (12):
qa/051: tweak "off net" filtering a little
qa/051: really (!) fix "off net" filtering
qa/008.out.bozo+sdc: update for new disk inventory
src/include/pcp.env: rework for _get_pids_by_name()
assorted: retire _get_pids_by_args() use _get_pids_by_name() -a
qa/common: use -a option to _get_pids_by_name to find primary pmlogger
qa/893: better diags, tweaks after _get_pids_by_name() changes
qa/635: deal with repeated interfaces reported from ifconfig
qa/230: _get_pids_by_name() needs -a to find drain-server QA process
src/include/pcp.mingw: mimic _get_pids_by_name() changes from pcp.env
src/pmcd/pmdaproc.sh: need -a for _get_pids_by_name
src/pmcd/rc-proc.sh: need -a option to _get_pids_by_name
qa/008.out.bozo+sdc | 17 +++---
qa/051 | 17 +++---
qa/230 | 11 ++-
qa/635 | 12 +++-
qa/893 | 21 ++++---
qa/common | 2
src/include/pcp.env | 56 ++++++++++++++-----
src/include/pcp.mingw | 133 ++++++++++++++++++++++++++++++++++++++++++-----
src/pmcd/pmdaproc.sh | 2
src/pmcd/rc-proc.sh | 2
src/pmcd/rc_pmcd | 51 ++++++++++--------
src/pmsignal/pmsignal.sh | 2
12 files changed, 245 insertions(+), 81 deletions(-)
Details ...
commit dc270582c1b8217499963183d9b005c103a5e940
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Sep 27 09:57:37 2016 +1000
src/pmcd/rc-proc.sh: need -a option to _get_pids_by_name
In this context, we probably need to preserve the historical semantics
with the more generous matching of the process name.
commit bed3e1b79da7f0a1bf4a9178eb3b9e5fb6391db6
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Sep 27 09:32:59 2016 +1000
src/pmcd/pmdaproc.sh: need -a for _get_pids_by_name
When killing off PMDAs, the binary may not be in the invoking shell's
$PATH (e.g. hidden in $PCP_VAR_LIB/pmda/pmdafoo), so we need the -a
option to (the new) _get_pids_by_name() function.
commit 816c90325f84a78f73c040590bf0e0090ab2e4d1
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Sep 27 09:31:42 2016 +1000
src/include/pcp.mingw: mimic _get_pids_by_name() changes from pcp.env
Unfortunately I have no way to test this on a Windows platform, so
this is a "best guess" effort.
commit 643bc8d211b00a62d4f93322cfd4847c13374090
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Sep 27 09:29:40 2016 +1000
qa/230: _get_pids_by_name() needs -a to find drain-server QA process
Also, make sure any zombie drain-server from another life is killed
off before starting, to avoid bind() failing with addr in use error.
commit 89d5a470c888edd9efe140169db0de27351b79f5
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Sep 27 06:24:53 2016 +1000
qa/635: deal with repeated interfaces reported from ifconfig
In my case it was br1 and br1:avahi after some recent network
reconfiguration, and these both map to br1 in the QA test and
the duplicated entry was causing a failure.
commit 2fb95840f45f21b757296bc5597e7857da1ec965
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 26 20:10:20 2016 +1000
qa/893: better diags, tweaks after _get_pids_by_name() changes
commit 710dbc7195892876e937ba893b9f8d1577a3fc4b
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 26 20:08:59 2016 +1000
qa/common: use -a option to _get_pids_by_name to find primary pmlogger
Looking for 'pmlogger .*-P' which now needs -a option.
commit 7dc8d828c9b1c6afeee2ebf6e043f03861ae77ab
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 26 20:05:53 2016 +1000
assorted: retire _get_pids_by_args() use _get_pids_by_name() -a
Use new -a option to _get_pids_by_name to match process name using
the less restrictive pattern '.*/name '.
With the additon of -a for _get_pids_by_name(), _get_pids_by_args()
is no longer required ... remove uses, but retain function for
backawards compatibility.
commit b49e85966f8fc332479ace7c17bb732aa5815483
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 26 20:03:45 2016 +1000
src/include/pcp.env: rework for _get_pids_by_name()
Need to restore original .*/name matching for process name in some
cases ... new -a option adds this to the set of matching algothims
that are used.
commit 2bae53f2ed45d46aa3dbb8a89b84b6b22ea0adb0
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Sep 26 20:03:01 2016 +1000
qa/008.out.bozo+sdc: update for new disk inventory
commit e4e8a6294ff8d5c4023e4c3c36f87c5ac518a309
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sat Sep 24 06:31:42 2016 +1000
qa/051: really (!) fix "off net" filtering
commit bc5d490091a596e0c0bbf840893fe46e586f670b
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu Sep 22 08:09:14 2016 +1000
qa/051: tweak "off net" filtering a little
|