pcp
[Top] [All Lists]

Re: [pcp] problem in qa/884 (libpcp_web)

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: [pcp] problem in qa/884 (libpcp_web)
From: Lukas Berk <lberk@xxxxxxxxxx>
Date: Tue, 06 Sep 2016 10:09:29 -0400
Cc: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>, PCP <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <693061586.5762447.1473147384317.JavaMail.zimbra@xxxxxxxxxx> (Nathan Scott's message of "Tue, 6 Sep 2016 03:36:24 -0400 (EDT)")
References: <5257a34f-b310-15b3-d2e2-78cb35bd48de@xxxxxxxxxxxxxxxx> <693061586.5762447.1473147384317.JavaMail.zimbra@xxxxxxxxxx>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
Hi,

Nathan Scott <nathans@xxxxxxxxxx> writes:
> ----- Original Message -----
>> I'm seeing problems with qa/884.
>> 
>> The checked in 884.out contains suspicious negative 32-bit values for
>> osd/stat_bytes* ...
> Hmm, yes, it looks like the parsing code is assuming signed 32 bit values
> for all JSON numbers.  I think to fix this Lukas we'll need to extend the
> "flags" field in the json_metric_desc to specify type?  (in a back-compat
> way such that no flag means signed int).

Thanks for catching this Ken.  Nathan, will start taking a look into
the fix today.

Cheers,

Lukas

<Prev in Thread] Current Thread [Next in Thread>