pcp
[Top] [All Lists]

pcp updates - merge kenj (qa, build issues, fix sed usage)

To: PCP <pcp@xxxxxxxxxxx>
Subject: pcp updates - merge kenj (qa, build issues, fix sed usage)
From: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Mon, 5 Sep 2016 10:54:58 +1000
Delivered-to: pcp@xxxxxxxxxxx
Changes committed to git://git.pcp.io/pcp master

Ken McDonell (10):
      qa/common.qt: avoid using dbus-launch
      qa/admin/pcp-daily: check if pcp.env exists before sourcing it
      src/libpcp/check-statics: rework for OpenIndiana
      src/libpcp: fix small portability issues found with OpenIndiana compilers
      qa/admin/check-vm: a small OpenIndiana change from netstat(1) difference
      src/libpcp_web/src/http_parser.h: clean up typedefs
      debian/libpcp-web1-dev.install: fix build breakage
      src/pmcd/GNUmakefile: fix sed(1) usage
      assorted service.in -> service makefile changes
      qa/527: filter out another variant of the perl line numbering buglet

 debian/libpcp-web1-dev.install   |    1
 qa/527                           |    3 -
 qa/admin/check-vm                |  108 +++++++++++++++++++++++++++++++--------
 qa/admin/pcp-daily               |    7 ++
 qa/common.qt                     |   16 +++++
 src/libpcp/src/check-statics     |   64 +++++++++++++++++++++--
 src/libpcp/src/connectlocal.c    |    2
 src/libpcp/src/derive.c          |    2
 src/libpcp/src/util.c            |   15 ++---
 src/libpcp_web/src/http_parser.h |   14 +----
 src/pmcd/GNUmakefile             |    2
 src/pmie/GNUmakefile             |    2
 src/pmlogger/GNUmakefile         |    2
 src/pmmgr/GNUmakefile            |    2
 src/pmproxy/GNUmakefile          |    2
 src/pmwebapi/GNUmakefile         |    2
 16 files changed, 189 insertions(+), 55 deletions(-)

Details ...

commit d7fd423bbfbc49e9f149ba8cb0d1952330492ed7
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sun Sep 4 17:48:13 2016 +1000

    qa/527: filter out another variant of the perl line numbering buglet

commit e1d3cbb9319d95f4926e84ab6a5a6ad6a7167a84
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sun Sep 4 17:07:24 2016 +1000

    assorted service.in -> service makefile changes

    Same sed(1) usage problem as fixed in the previous commit ...

    The sloppiness from the GNU implementation of getopt* is not universal
    and putting command line options after command line arguments is not a
    good idea ... specifically sed file -e edit is not always acceptable,
    and to be properly portable one needs to avoid this command line mess
    and stick with the classical usage, namely sed -e edit file

commit 0189bdb8547f04c590a8dd081d47285865df92af
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sun Sep 4 16:54:52 2016 +1000

    src/pmcd/GNUmakefile: fix sed(1) usage

    The sloppiness from the GNU implementation of getopt* is not universal
    and putting command line options after command line arguments is not a
    good idea ... specifically sed file -e edit is not always acceptable,
    and to be properly portable one needs to avoid this command line mess
    and stick with the classical usage, namely sed -e edit file

commit 012f983653467a14a70b091fcdc564024fcc2fb1
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sun Sep 4 07:36:36 2016 +1000

    debian/libpcp-web1-dev.install: fix build breakage

    The recently added pmhttp.h was being installed but not packaged
    for Debian builds ... which broke all the Debian-related builds.

commit f08a4a63e097a9287af32ff648f14be22e09e265
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sun Sep 4 07:09:32 2016 +1000

    src/libpcp_web/src/http_parser.h: clean up typedefs

    For some compilers,

    typedef struct foo foo; /* empty for forward ref */
    ...
    typedef struct foo {
    ... real struct decl ...
    } foo;

    is not allowed ... this was breaking the build.

    In this particular case the forward refs are not needed with some
    small re-ordering of declarations in http_parser.h

commit 3b65eb29806019c35259b5fd94e61f008320ff19
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sun Sep 4 07:08:53 2016 +1000

    qa/admin/check-vm: a small OpenIndiana change from netstat(1) difference

commit 04149d1b3dba770461b6952ec6e6794805639519
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sat Sep 3 07:55:59 2016 +1000

    src/libpcp: fix small portability issues found with OpenIndiana compilers

commit 231fcac8948f6c47f49964d003f564f313ccc2fb
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sat Sep 3 07:53:16 2016 +1000

    src/libpcp/check-statics: rework for OpenIndiana

commit fabc3699a62aca942ba395cc139c6e69295f078e
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sat Sep 3 07:39:40 2016 +1000

    qa/admin/pcp-daily: check if pcp.env exists before sourcing it

commit 5ffca3dbf77ad364c191568a100cc5bc9132d56a
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Sat Sep 3 07:36:24 2016 +1000

    qa/common.qt: avoid using dbus-launch

    To address https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836285
    replace dbus-launch by a direct invocation of dbus-daemon.

<Prev in Thread] Current Thread [Next in Thread>
  • pcp updates - merge kenj (qa, build issues, fix sed usage), Mark Goodwin <=