pcp
[Top] [All Lists]

Bug#836285: pcp: please use dbus-run-session, or dbus-daemon directly, i

To: maintonly@xxxxxxxxxxxxxxx
Subject: Bug#836285: pcp: please use dbus-run-session, or dbus-daemon directly, in tests
From: Simon McVittie <smcv@xxxxxxxxxx>
Date: Thu, 1 Sep 2016 12:27:53 +0100
Delivered-to: pcp@xxxxxxxxxxx
Delivered-to: maintonly@xxxxxxxxxxxxxxx
Reply-to: Simon McVittie <smcv@xxxxxxxxxx>, 836285-maintonly@xxxxxxxxxxxxxxx
Resent-date: Thu, 01 Sep 2016 11:30:02 +0000
Resent-from: Simon McVittie <smcv@xxxxxxxxxx>
Resent-message-id: <handler.836285.M.147272927519065@xxxxxxxxxxxxxxx>
Resent-to: PCP Development Team <pcp@xxxxxxxxxxx>
User-agent: NeoMutt/ (1.7.0)
Source: pcp
Version: 3.11.3.1
Severity: normal
Tags: upstream
User: dbus@xxxxxxxxxxxxxxxxxxx
Usertags: dbus-launch dbus-launch-for-tests

As described in <https://lists.debian.org/debian-devel/2016/08/msg00554.html>
I'm trying to reduce how much dbus-launch is used in Debian.
This package currently uses dbus-launch if it exists (without a dependency
on dbus-x11, so it is not guaranteed to exist) in what appear to be some
sort of regression tests, in "./qa/common.qt".

This is really an upstream issue, and I'm not sure whether these tests are
even run in Debian.

This Flatpak commit illustrates how (the equivalent of) eval `dbus-launch`
can be replaced by invoking dbus-daemon directly, avoiding the X11-specific
and semi-deprecated dbus-launch executable:
<https://github.com/flatpak/flatpak/commit/6cc8062cfb3f9410d54a27e7ccca77c103e441e8>.

Alternatively, the test executable could be run through
dbus-run-session(1), which is available since dbus 1.8, the upstream
"old stable" branch available since early 2014, and currently the
oldest branch with security support:

    dbus-run-session -- some-test

That would allow removal of all the special code to start and stop
the dbus-daemon.

Thanks,
    S

<Prev in Thread] Current Thread [Next in Thread>