On 02/08/16 10:41, Nathan Scott wrote:
Hi Ken,
----- Original Message -----
...
I guess the other place to still consider is the pmlc PDUs, but they
are never multiplexed so probably not an area to really worry about.
These were already accounted for, but I've done a better job of this and
the other outlier __pmGetPDU() uses in the Mk II commit ... I think this
is done now in terms of appropriate checks and actions after all the
__pmGetPDU() uses.
I can't see any issues here. One slight tweak that might be worth
doing (maybe later - its an internal routine only) would be to have
the new __pmCloseChannel routine pull in the two lines that always
follow it, i.e. fixing up the error code to be one of TIMEOUT/IPC,
and returning that, instead of open-coding that logic for each PDU.
I considered this when I refactored __pmCloseChannel ->
{__pmCloseChannelbyContext and __pmCloseChannelbyFd} but decided not to.
I did not want to pass a int * status into the reporting routine and
then have the caller logic obfuscated by some hidden change to the value
of a (usually) local variable.
|