I think these should be included in the next release ... they complete the
changes (all __pmGetPDU() uses are now checked) and provided better failure
reporting via some changes to the internal API(s).
Changes committed to git://git.pcp.io/kenj/pcp master
Ken McDonell (4):
qa/512: re-audit and re-made .out file
src/libpcp/secureconnect.c: correct __pmSecureClientHandshake() error case
qa/admin/check-vm: small changes
src/libpcp & qa: ...CloseChannel...() Mk II
qa/169.out | 2 -
qa/200.out | 10 ++++----
qa/512.out | 11 +++++----
qa/865.out | 4 +--
qa/866.out | 20 ++++++++---------
qa/admin/check-vm | 10 --------
src/libpcp/src/connect.c | 11 +++++++--
src/libpcp/src/context.c | 47 ++++++++++++++++++++++++++++++++++++-----
src/libpcp/src/desc.c | 2 -
src/libpcp/src/fetch.c | 2 -
src/libpcp/src/help.c | 2 -
src/libpcp/src/instance.c | 6 ++---
src/libpcp/src/internal.h | 3 +-
src/libpcp/src/logcontrol.c | 8 +++++-
src/libpcp/src/pmns.c | 8 +++---
src/libpcp/src/secureconnect.c | 15 ++++++++-----
src/libpcp/src/secureserver.c | 12 ++++++----
src/libpcp/src/store.c | 2 -
18 files changed, 113 insertions(+), 62 deletions(-)
Details ...
commit b16423d79e56f32f15f8e462ee36756a061666c1
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Aug 3 10:01:42 2016 +1000
src/libpcp & qa: ...CloseChannel...() Mk II
New and improved, even without steak knives.
I've cleaned up the internal APIs ...
- better diagnostics to indicate what was expected as well as what
was received, namely the wrong PDU (unlikely, now but not so before
these changes), or PM_ERR_TIMEOUT (most likely) or some other error
(unlikely)
- renamed __pmCloseChannel() to __pmCloseChannelbyContext() for the
original use, but also added __pmCloseChannelbyFd() for the second
round of __pmGetPDU() uses where the context may not be available
... this includes the handshake interchanges during context setup
and pmlc-pmlogger interactions that are built on the same PDU
services and assume synchronous IPC (but there is no socket
multiplexing here, so no exposure to the original cascaded
problems after a __pmGetPDU() timeout.
commit de15fdcf06498d884971f55593c68aafcc8b8510
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Aug 3 09:59:59 2016 +1000
qa/admin/check-vm: small changes
1. fix certutil line for debian-based systems (broken by some previous
commit)
2. drop xclip ... not more than 3 people in 7 billion use the script
that uses xclip
commit e79b400e02ee4f276db394f6d133085dafcd1ca3
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Aug 3 07:19:24 2016 +1000
src/libpcp/secureconnect.c: correct __pmSecureClientHandshake() error case
In the case of an IPC, TIMEOUT or PDU protocol botch,
__pmSecureClientHandshake() was returning -PM_ERR_IPC, not PM_ERR_IPC
commit 3e4f29728aba73bced31b2955bc1ca9bf8fb5eab
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Aug 2 09:02:37 2016 +1000
qa/512: re-audit and re-made .out file
|