Hi Ken,
----- Original Message -----
> [...]
> Given the severity of the issue, it is hard to imagine these changes
> making the situation worse ... and they demonstrably make it better
> in a range of QA tests built to simulate the BZ 1158 failure signature.
>
> There are still some __getPDU() uses to be analyzed, but these all
> relate to context creation and should a similar problem occur there
> and be undetected the changes here will catch it almost immediately
> the real client-pmcd traffic starts.
I guess the other place to still consider is the pmlc PDUs, but they
are never multiplexed so probably not an area to really worry about.
I can't see any issues here. One slight tweak that might be worth
doing (maybe later - its an internal routine only) would be to have
the new __pmCloseChannel routine pull in the two lines that always
follow it, i.e. fixing up the error code to be one of TIMEOUT/IPC,
and returning that, instead of open-coding that logic for each PDU.
cheers.
--
Nathan
|